feat: added submitFormResponse mutation #17

psworld · 2023-10-08T02:46:11Z

What does this PR do?

Fixes #1

Added submitFormResponse Mutation. This allows to submit responses of a form created by a user.
Added getFormResponsesByFormId Query. This allows to query form responses based on form Id.
Created a database model named: FormResponse

Type of change

New feature (non-breaking change which adds functionality)

How should this be tested?

You can test this at http://localhost:8000/local/graphql -> mutation -> SubmitFormResponse

I have made sure that db model FormResponse keep those fields optional which are optional during creating a Form.

Only required fields are:

form   Form   @relation(fields: [formId], references: [id])
formId String @map("form_id")
userName    String   @map("user_name")
testimonial String   @map("testimonial")

All the necessary changes required for the above changes are done at their respective places.
No unnecessary change has been done.

github-actions · 2023-10-08T02:46:24Z

Thank you for following the naming conventions! 🙏

psworld · 2023-10-08T02:49:06Z

@piyushgarg-dev Hello sir, kindly review the changes.

If any other change is required please let me know,

and if everything is right, please merge my PR

piyushgarg-dev · 2023-10-08T06:26:33Z

Great Work 🎉

piyushgarg-dev

Here are few changes 😄 Thanks a lot for contributing 🙏🏻

piyushgarg-dev · 2023-10-08T06:28:17Z

prisma/schema.prisma

+  userName    String   @map("user_name")
+  userEmail   String?  @unique @map("user_email")
+  userImage   String?  @map("user_image")
+  rating      Int?
+  testimonial String   @map("testimonial")
+  jobTitle    String?  @map("job_title")
+  websiteUrl  String?  @map("website_url")
+  company     String?
+  createdAt   DateTime @default(now()) @map("created_at")
+  updatedAt   DateTime @updatedAt @map("updated_at")


Can we drop the word user?
We can have something like

name String email String? imageURL String? @map("image_url")

piyushgarg-dev · 2023-10-08T06:29:32Z

prisma/schema.prisma

+  formId String @map("form_id")
+
+  userName    String   @map("user_name")
+  userEmail   String?  @unique @map("user_email")


Drop the @unique here as one user can submit multiple feedbacks also.

Maybe in future, we can have a composite unique of formId+email to enforce one entry per form.

piyushgarg-dev · 2023-10-08T06:31:05Z

functions/graphql/form/interfaces.ts

+  company?: string
+}
+
+export interface GetFormResponsesInput {


Let's rename this to GetFormResponsesByFormIdInput

piyushgarg-dev · 2023-10-08T06:34:06Z

functions/graphql/form/resolver.ts

+    const form = await FormService.getFormById(formId)
+
+    if (!form) {
+      throw new Error('No form exist with given id')


Replace the throw Error with BadRequestError from errors/BadRequestError.ts

piyushgarg-dev · 2023-10-08T06:34:57Z

functions/graphql/form/resolver.ts

+    const { formId, ...otherData } = data
+
+    //Check if form exist with given id
+    const form = await FormService.getFormById(formId)


Can we include a select here as this would do SELECT * from DB which is expensive 😄

piyushgarg-dev · 2023-10-08T06:37:01Z

functions/graphql/form/resolver.ts

+    { data }: { data: SubmitFormResponseData },
+    ctx: ServerContext
+  ) => {
+    const { formId, ...otherData } = data


This can be dangerous as ...otherdata can bring any data which would go into DB.
Destructure each value and insert it in DB for security 😄

Example:

review-app-api/functions/graphql/form/resolver.ts

Lines 30 to 48 in 93a0f92

const form = await FormService.createForm({

data: {

name,

slug: slugify(slug),

introTitle: 'Share a testimonial!',

introMessage: `Do you love using our product? We'd love to hear about it! - Share your experience with a quick video or text testimonial - Recording a video? Don't forget to smile 😊`,

promptTitle: 'Write a testimonial',

promptDescription: `- What do you like most about us?\n- Would you recommend us to a friend?`,

thankyouTitle: 'Thank you 🙏',

thankyouMessage:

'Thank you so much for your support! We appreciate your support and we hope you enjoy using our product.',

autoApproveTestimonials: false,

autoAddTags: [],

primaryColor: '#8B41F2',

backgroundColor: '#FFFFFF',

createdBy: { connect: { id: ctx.user?.id! } },

project: { connect: { id: projectId } },

},

})

piyushgarg-dev · 2023-10-08T13:12:33Z

Hi @psworld
Are you working on this issue?

Thanks 😄

psworld · 2023-10-08T13:15:54Z

Hi @psworld Are you working on this issue?

Thanks 😄

@piyushgarg-dev

Yes, sir. almost done.

should I add videoTestimonialURL to my FormResponse model ?

piyushgarg-dev · 2023-10-08T13:17:33Z

We can take it up in different issue 😄

psworld · 2023-10-08T13:23:47Z

@piyushgarg-dev kindly review the new commit. I have made all the changes suggested by you.

If there are any more changes required please let me know

psworld · 2023-10-08T13:39:20Z

@piyushgarg-dev Are the migrations causing difficulties ? I just saw the migrations, I am working to reset the migration to main branch, and add only one migration to create the form_responses table. Please allow some time

piyushgarg-dev · 2023-10-08T13:40:09Z

Great @psworld
I'll merge this once I am done with testing 😄

piyushgarg-dev · 2023-10-08T13:41:11Z

@psworld Can you please merge the lastest main branch into your code?

psworld · 2023-10-08T13:42:15Z

@psworld Can you please merge the lastest main branch into your code?

Yes sir, I will do that

piyushgarg-dev · 2023-10-08T14:10:27Z

Hi @psworld Can you please merge #29 this PR to your branch and will merge it

…bmit_form

psworld · 2023-10-08T15:14:29Z

@piyushgarg-dev hello sir, thankyou for your patience.
I was facing some problem using git.

I fetched upstream/feat/submit_form and then merged to my feat/submit_form branch
I also fetched upstream/main and merged it with my feat/submit_form so my branch is upto date with latest changes in main

then I committed and pushed all the changes to my feat/submit_form branch.

hopefully this what you wanted.
Again thankyou for your patience.
Please let me know if any more changes are required.

piyushgarg-dev · 2023-10-08T15:18:55Z

Great Work @psworld
Merged 🎉

psworld · 2023-10-08T15:27:39Z

Great Work @psworld Merged 🎉

@piyushgarg-dev Thankyou so much sir ! and really thankyou for your patience with me.

I am a complete newbie , I only knew basic python, just saw your hackoberfest video at around 2 am at night and decided to contribute.
Haven't slept from past 1 day, but it was all worth it. I got to learn so much. Thankyou so much for providing me with this opportunity 😊
Hopefully I will be able to contribute more in future 🙏

and also really love your teaching style

psworld · 2023-10-08T17:33:49Z

@piyushgarg-dev Hello sir.

There is a small error in ordering of migration files:

20231008135244_added_approve_tags_to_forms is coming before 20231008144348_added_form_response_table. This is causing reference error as added_approve_tags_to_forms is refrencing form_responses table in its SQL but it is not yet present is database.

The added_form_response_table migration should be applied first and then added_approve_tags_to_forms. Currently it's the opposite.

currently if you run yarn prisma:migrate:local will give you error Error: The underlying table for model form_responses does not exist.

By manually exchanging and renaming the migration files and putting them in correct order, no error occur while running yarn prisma:migrate:local and all migrations are successful.
But this will drop the existing SCHEMA when applying the migrations and all local data of database will be lost.

Should I make submit with correct order of migration files, in this same branch feat/submit_form or should I open a new issue ?

feat: added submitFormResponse mutation

961f2e4

piyushgarg-dev requested changes Oct 8, 2023

View reviewed changes

Merge branch 'main' into feat/submit_form

ec56deb

Made changes suggested by @piyushgarg-dev to PR piyushgarg-dev#17

619cf00

piyushgarg-dev added 2 commits October 8, 2023 19:23

refactor: added approve and tags to columns

42c08d5

fix: added auth check

476d13d

piyushgarg-dev mentioned this pull request Oct 8, 2023

feat: added submitFormResponse mutation #29

Merged

1 task

Ps added 3 commits October 8, 2023 20:09

removed old moigrations

b80f7c7

Corrected migrations to match with main

8e0a6d1

Merge remote-tracking branch 'upstream/feat/submit_form' into feat/su…

f1f7082

…bmit_form

piyushgarg-dev added hacktoberfest Hacktoberfest Accepted Issues hacktoberfest-accepted Hacktoberfest Accepted labels Oct 8, 2023

piyushgarg-dev assigned psworld Oct 8, 2023

piyushgarg-dev merged commit bacb6ce into piyushgarg-dev:main Oct 8, 2023
2 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: added submitFormResponse mutation #17

feat: added submitFormResponse mutation #17

psworld commented Oct 8, 2023

github-actions bot commented Oct 8, 2023 •

edited

Loading

psworld commented Oct 8, 2023

piyushgarg-dev commented Oct 8, 2023

piyushgarg-dev left a comment

piyushgarg-dev Oct 8, 2023

piyushgarg-dev Oct 8, 2023

piyushgarg-dev Oct 8, 2023

piyushgarg-dev Oct 8, 2023

piyushgarg-dev Oct 8, 2023

piyushgarg-dev Oct 8, 2023 •

edited

Loading

piyushgarg-dev commented Oct 8, 2023

psworld commented Oct 8, 2023

piyushgarg-dev commented Oct 8, 2023

psworld commented Oct 8, 2023

psworld commented Oct 8, 2023

piyushgarg-dev commented Oct 8, 2023

piyushgarg-dev commented Oct 8, 2023

psworld commented Oct 8, 2023

piyushgarg-dev commented Oct 8, 2023

psworld commented Oct 8, 2023

piyushgarg-dev commented Oct 8, 2023

psworld commented Oct 8, 2023

psworld commented Oct 8, 2023

	const form = await FormService.createForm({
	data: {
	name,
	slug: slugify(slug),
	introTitle: 'Share a testimonial!',
	introMessage: `Do you love using our product? We'd love to hear about it! - Share your experience with a quick video or text testimonial - Recording a video? Don't forget to smile 😊`,
	promptTitle: 'Write a testimonial',
	promptDescription: `- What do you like most about us?\n- Would you recommend us to a friend?`,
	thankyouTitle: 'Thank you 🙏',
	thankyouMessage:
	'Thank you so much for your support! We appreciate your support and we hope you enjoy using our product.',
	autoApproveTestimonials: false,
	autoAddTags: [],
	primaryColor: '#8B41F2',
	backgroundColor: '#FFFFFF',
	createdBy: { connect: { id: ctx.user?.id! } },
	project: { connect: { id: projectId } },
	},
	})

feat: added submitFormResponse mutation #17

feat: added submitFormResponse mutation #17

Conversation

psworld commented Oct 8, 2023

What does this PR do?

Type of change

How should this be tested?

github-actions bot commented Oct 8, 2023 • edited Loading

psworld commented Oct 8, 2023

piyushgarg-dev commented Oct 8, 2023

piyushgarg-dev left a comment

Choose a reason for hiding this comment

piyushgarg-dev Oct 8, 2023

Choose a reason for hiding this comment

piyushgarg-dev Oct 8, 2023

Choose a reason for hiding this comment

piyushgarg-dev Oct 8, 2023

Choose a reason for hiding this comment

piyushgarg-dev Oct 8, 2023

Choose a reason for hiding this comment

piyushgarg-dev Oct 8, 2023

Choose a reason for hiding this comment

piyushgarg-dev Oct 8, 2023 • edited Loading

Choose a reason for hiding this comment

piyushgarg-dev commented Oct 8, 2023

psworld commented Oct 8, 2023

piyushgarg-dev commented Oct 8, 2023

psworld commented Oct 8, 2023

psworld commented Oct 8, 2023

piyushgarg-dev commented Oct 8, 2023

piyushgarg-dev commented Oct 8, 2023

psworld commented Oct 8, 2023

piyushgarg-dev commented Oct 8, 2023

psworld commented Oct 8, 2023

piyushgarg-dev commented Oct 8, 2023

psworld commented Oct 8, 2023

psworld commented Oct 8, 2023

github-actions bot commented Oct 8, 2023 •

edited

Loading

piyushgarg-dev Oct 8, 2023 •

edited

Loading