Skip to content

Travel page on the Gameplay tab: 190 places, each with a picture from your own game - #58

Merged
pixl27 merged 3 commits into
pixl27:mainfrom
samaBR85:feat/travel-places
Nov 16, 2026
Merged

pixl27 merged 3 commits into
pixl27:mainfrom
samaBR85:feat/travel-places

Conversation

@samaBR85

Copy link
Copy Markdown
Contributor

The Travel page

A picture taken: the notice over the game

The Gameplay tab with the new rows

Summary:

  • Travel (Gameplay): a page of 190 places to go to (villages, dungeons' entrances, shops, warp points, story spots), grouped by area. It lists Link's age's places; Tab, X or a click on Child / Adult shows the other age's (going there makes Link that age).
  • Each place has a picture taken from the player's own game the first time Link stays there a few seconds with the menu closed (the middle of the picture at 480x270, one file a place in teleport_pictures), with a short "Travel picture saved" line over the game. Y or Backspace on the page takes a place's picture again at the next stay there. Nothing is shipped.
  • Link arrives through the game's own map change, at the place's own entrance with its arrival event, as when he walks in. The places' positions, arrival events and story flags come from the player's RomFS at every build (nx2/teleport_places.py, zstandard only, into teleport_places.bin).

Why:
The Cheats page's Teleport goes to 31 maps' starts by name. This is a port of Longshot's Teleport places and pictures (MagicBeanDev/Longshot#823, originally Hookshot), where players asked to see where they are going. It uses the same event request as the Cheats teleport (oot_teleport), plus the Fast Travel mod's carrier warp for the points no entrance leads to.

A choice for you: I put the page on the Gameplay tab, for everyone. If you would rather keep travel among the private tools, the same page can open from the Cheats page instead (one row moved); just say so.

How it fits ReLink:

  • gpu/vk/oot_tp_places.h, oot_tp_places_data.h, oot_teleport_capture.h (new): the places, their data file and the ids between the two sides.
  • host/hos_main.c: oot_travel_place (the age set first when it differs, then oot_teleport to the place's spawn with its event), oot_capture_tick (Link settled near a place for 3 s, no event, no map loading), and Link's age published with the inventory counts.
  • gpu/vk/vk_menu.cpp: the page (GDI, the picture written into the menu's bitmap), a worker thread that reads and writes the picture files (a present never waits on the disk), and the notice; vk_replay.cpp teleport_capture (a blit at present time, read back at the next present).
  • option id 43 (HOS_OPT_TELEPORT_PICTURES).

Tested on Windows 11, RTX 4070 SUPER, on ReLink 0.7.5 to 0.7.6, rebased on 0.7.7 (builds): travel to places as child and adult and to the other age's places, pictures taken and shown, the notice, retaking a picture, the mouse, Tab and the pad.

Not tested: Linux, AMD and Intel GPUs.

…a picture taken in your own game

Ported from Longshot (MagicBeanDev/Longshot#823, from Hookshot's Teleport pictures): the places a Fast Travel mod offers
(villages, dungeons' entrances, shops, warps, story spots) grouped by area for Link's age, each with a picture taken the
first time Link stays there; Link arrives through the game's own map change. The places' positions and arrival events come
from the player's own RomFS at every build (nx2/teleport_places.py). ReLink's menu is GDI: the page draws the picture into
the menu's bitmap.

Feito com Claude Code
@Yel1oww Yel1oww mentioned this pull request Nov 15, 2026
@pixl27

pixl27 commented Nov 16, 2026

Copy link
Copy Markdown
Owner

Thanks for this, and for the care in the write-up. I went through every added line and built it; here is where it stands.

Nothing unsafe. No network, no process, no DLL, no registry; the picture files only ever go to teleport_pictures\<key>.bin with names from the compile-time list; the places reader survives a missing or corrupt file; nx2/teleport_places.py reads the RomFS and writes one file, and resolved 190 of 190 places in 4 s here. The repository gets nothing of the game.

Changes I've made on top of your commit (a branch on my side, review-58; I'll push them with the merge):

  1. vk_api.h back to what it is on main. That file is part of the shader cache's stamp: the three added lines would have made every player prepare their shaders again at the update. The option id now lives in oot_teleport_capture.h and still travels through the existing option call.
  2. Pictures only start once the player has opened the Travel page. As submitted, menu_teleport_captures_on() returned true for everyone, so every player got pictures written and the "Travel picture saved" line, even without ever opening the menu.
  3. The Linux host didn't compile: oot_places_data() was called from the Linux-only main but defined under #ifdef _WIN32. It is read at the start of the Windows game now, as your comment intended.
  4. Ten places are in both ages' lists with the same key and the reader stopped at the first match, so the ten adult copies had no data (the adult Spirit Temple entrance arrived by the warp instead of its own arrival event). Fixed in the reader.
  5. The picture's read-back no longer blocks a present (it held replay_mu in wait_value).
  6. Comments reworded so they don't name other projects (house rule here; the readme's License section carries the origin).

Two things I need from you before it can go in:

  • gpu/vk/oot_tp_places.h says the place list comes from the Fast Travel mod, under MIT. MIT asks for that mod's copyright line and permission notice to travel with the copy. Could you add them to NOTICE.md in this PR (the exact copyright line from the mod's license)? I'd rather not guess it.
  • Save safety. The page writes Link's age and, for the 60 warp places, the next map through a hard-coded setter, and the next save keeps them. There's no guard for story progress: a fresh child save can become adult without the Master Sword, or land in a boss room. Have you tried what those post-boss and story spawn points do to a save that hasn't reached them? Anything you've seen helps.

Where it goes in the menu. You offered Gameplay or the Cheats page. Free travel plus an age switch is a cheat in effect, so that's the owner's call and I've asked; I'll tell you here.

Still to do on my side: a full game build with this and a run through the arrivals, the age switch and the pictures. I'll report back here.

@samaBR85

Copy link
Copy Markdown
Contributor Author

Thank you for going through all of it so closely, and for the fixes. The six changes on review-58 all look right to me (the shader cache stamp and the Linux build are things I hadn't thought of, and pictures only after the page is opened is better).

NOTICE.md: added in b45a360, the Fast Travel mod's copyright line and MIT permission notice, copied from the mod's LICENSE as it is today in https://github.com/afiaka87/oots2-release ("Copyright (c) 2026 HanSoloBlaster, afiaka87"; an older copy I had said "Clay Mullis", the current file is what's in the commit).

Save safety: honestly, no, I haven't tried it. Every test was on saves already past those points, so I can't tell you what a fresh child save does after becoming adult without the Master Sword, or after landing in a boss room or a post-boss spot it hasn't reached. The page has no story guard, same as the mod it comes from.

If it stays on Gameplay, I can add a guard, for example:

  • the adult side only once the Master Sword has been pulled (and the child side only for a save that has been a child, which is every save);
  • boss rooms and post-boss/story spots only once that dungeon or event is done, from the game's own flags.

Or, if the owner puts it on the Cheats page, it may be fine as a cheat without one. Tell me which way you want it and I'll do it; I can also run a fresh save through the warp places and report what each does.

@samaBR85

Copy link
Copy Markdown
Contributor Author

A correction and a decision on the save question, after checking with the person who tested it in the game:

What happens to a save: a child who goes adult before pulling the Master Sword is an adult with the Kokiri Sword. The Hylian Shield can still be had as adult (the graveyard, or bought in the shop). To get the adult sword, the player goes back to being a child and moves the story on until the Master Sword is pulled, as in the normal game. So the save isn't broken, the player is just ahead of the story.

Where it goes: our preference is the Cheats page, with no story guard. Free travel and the age switch are cheat functions, and they should stay usable as such, so I'll drop the guard idea from my last comment.

Since you're holding changes on review-58, moving the row to the Cheats page is probably easiest on your side to avoid a conflict, but if you'd rather I push it here, just say so and I'll do it.

@pixl27

pixl27 commented Nov 16, 2026

Copy link
Copy Markdown
Owner

Thanks for the notice (b45a360) and for the straight answer on saves; that settles both points. The Cheats page it is, with no story guard.

0.7.8 went out a few minutes before your commit, with the item wheel and without Travel, so Travel goes into the next release. On my side, in this order: your notice, the review changes, the row moved to the Cheats page, then a run through the arrivals, the age switch and the pictures on the release build, and the merge. No need to push anything else; I'll say here when it's in.

@pixl27
pixl27 merged commit 328b564 into pixl27:main Nov 16, 2026
2 checks passed
@pixl27

pixl27 commented Nov 16, 2026

Copy link
Copy Markdown
Owner

Merged. Thanks for this, and for sorting the notice out so quickly.

What is on main now: your work as one commit (328b564), then mine on top: the six review changes listed above, the row moved to the Cheats page (its last row, "Travel"; Esc on the page goes back to Cheats; with no HOS_OOT_CHEATS=1 the page can't be opened and no picture is taken), and the places' header pointing at NOTICE.md.

Tested in game on the merged tree (RTX 3060 Ti): the page opens from Cheats, the first place takes Link to the front of the Deku Tree through the game's own map change, its picture is taken after the stay and shows on the page the next time; without the cheats switch, the same keys reach nothing of Travel and the pictures folder doesn't change. Not tested here: the adult side, the 60 warp-only places, the mouse on the page, Linux (the page is Windows-only for now, as the places are read in the Windows start).

To let GitHub squash it I pushed a merge of main onto your branch (1f561e3), nothing else. It ships in the next release, together with button prompts for Xbox and PlayStation pads.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants