Repository navigation
Travel page on the Gameplay tab: 190 places, each with a picture from your own game - #58
Conversation
…a picture taken in your own game Ported from Longshot (MagicBeanDev/Longshot#823, from Hookshot's Teleport pictures): the places a Fast Travel mod offers (villages, dungeons' entrances, shops, warps, story spots) grouped by area for Link's age, each with a picture taken the first time Link stays there; Link arrives through the game's own map change. The places' positions and arrival events come from the player's own RomFS at every build (nx2/teleport_places.py). ReLink's menu is GDI: the page draws the picture into the menu's bitmap. Feito com Claude Code
|
Thanks for this, and for the care in the write-up. I went through every added line and built it; here is where it stands. Nothing unsafe. No network, no process, no DLL, no registry; the picture files only ever go to Changes I've made on top of your commit (a branch on my side,
Two things I need from you before it can go in:
Where it goes in the menu. You offered Gameplay or the Cheats page. Free travel plus an age switch is a cheat in effect, so that's the owner's call and I've asked; I'll tell you here. Still to do on my side: a full game build with this and a run through the arrivals, the age switch and the pictures. I'll report back here. |
|
Thank you for going through all of it so closely, and for the fixes. The six changes on NOTICE.md: added in b45a360, the Fast Travel mod's copyright line and MIT permission notice, copied from the mod's Save safety: honestly, no, I haven't tried it. Every test was on saves already past those points, so I can't tell you what a fresh child save does after becoming adult without the Master Sword, or after landing in a boss room or a post-boss spot it hasn't reached. The page has no story guard, same as the mod it comes from. If it stays on Gameplay, I can add a guard, for example:
Or, if the owner puts it on the Cheats page, it may be fine as a cheat without one. Tell me which way you want it and I'll do it; I can also run a fresh save through the warp places and report what each does. |
…of places Feito com Claude Code
|
A correction and a decision on the save question, after checking with the person who tested it in the game: What happens to a save: a child who goes adult before pulling the Master Sword is an adult with the Kokiri Sword. The Hylian Shield can still be had as adult (the graveyard, or bought in the shop). To get the adult sword, the player goes back to being a child and moves the story on until the Master Sword is pulled, as in the normal game. So the save isn't broken, the player is just ahead of the story. Where it goes: our preference is the Cheats page, with no story guard. Free travel and the age switch are cheat functions, and they should stay usable as such, so I'll drop the guard idea from my last comment. Since you're holding changes on |
|
Thanks for the notice (b45a360) and for the straight answer on saves; that settles both points. The Cheats page it is, with no story guard. 0.7.8 went out a few minutes before your commit, with the item wheel and without Travel, so Travel goes into the next release. On my side, in this order: your notice, the review changes, the row moved to the Cheats page, then a run through the arrivals, the age switch and the pictures on the release build, and the merge. No need to push anything else; I'll say here when it's in. |
|
Merged. Thanks for this, and for sorting the notice out so quickly. What is on Tested in game on the merged tree (RTX 3060 Ti): the page opens from Cheats, the first place takes Link to the front of the Deku Tree through the game's own map change, its picture is taken after the stay and shows on the page the next time; without the cheats switch, the same keys reach nothing of Travel and the pictures folder doesn't change. Not tested here: the adult side, the 60 warp-only places, the mouse on the page, Linux (the page is Windows-only for now, as the places are read in the Windows start). To let GitHub squash it I pushed a merge of |
Summary:
teleport_pictures), with a short "Travel picture saved" line over the game. Y or Backspace on the page takes a place's picture again at the next stay there. Nothing is shipped.nx2/teleport_places.py, zstandard only, intoteleport_places.bin).Why:
The Cheats page's Teleport goes to 31 maps' starts by name. This is a port of Longshot's Teleport places and pictures (MagicBeanDev/Longshot#823, originally Hookshot), where players asked to see where they are going. It uses the same event request as the Cheats teleport (
oot_teleport), plus the Fast Travel mod's carrier warp for the points no entrance leads to.A choice for you: I put the page on the Gameplay tab, for everyone. If you would rather keep travel among the private tools, the same page can open from the Cheats page instead (one row moved); just say so.
How it fits ReLink:
gpu/vk/oot_tp_places.h,oot_tp_places_data.h,oot_teleport_capture.h(new): the places, their data file and the ids between the two sides.host/hos_main.c:oot_travel_place(the age set first when it differs, thenoot_teleportto the place's spawn with its event),oot_capture_tick(Link settled near a place for 3 s, no event, no map loading), and Link's age published with the inventory counts.gpu/vk/vk_menu.cpp: the page (GDI, the picture written into the menu's bitmap), a worker thread that reads and writes the picture files (a present never waits on the disk), and the notice;vk_replay.cppteleport_capture(a blit at present time, read back at the next present).HOS_OPT_TELEPORT_PICTURES).Tested on Windows 11, RTX 4070 SUPER, on ReLink 0.7.5 to 0.7.6, rebased on 0.7.7 (builds): travel to places as child and adult and to the other age's places, pictures taken and shown, the notice, retaking a picture, the mouse, Tab and the pad.
Not tested: Linux, AMD and Intel GPUs.