Added possibility to handle progress during load #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CrazyFlasher
changed the title
andrewstart
requested changes
Sep 20, 2023
src/animate/load.ts
Outdated
| * @return instance of PIXI resource loader | ||
| */ | ||
| export function load(scene: AnimateAsset, complete?: Complete): void; |
There was a problem hiding this comment.
This function signature should remain unchanged - your implementation only handles it in a LoadOptions object (which I agree with doing).
src/animate/load.ts
Outdated
| if (!loadedAsset) | ||
| { | ||
| return; // not sure if this can evet happen | ||
| return; // not sure if this can event happen |
There was a problem hiding this comment.
While we are fixing typos, the typo here was that it should be even.
src/animate/load.ts
Outdated
| { | ||
| if (optionsOrComplete && typeof optionsOrComplete !== 'function') |
There was a problem hiding this comment.
A couple suggestions here:
- Save a local variable like
completeup above. - Since we already have a callback for each asset, instead of making a new function for each asset to pass to Assets, just do our progress calculation where you are doing
loadedAssets++(which will also ensure that the math is correct).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#142