-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrap experimental Local Chromium AI APIs as bricks #9310
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9310 +/- ##
==========================================
+ Coverage 74.24% 75.15% +0.90%
==========================================
Files 1332 1367 +35
Lines 40817 42188 +1371
Branches 7634 7843 +209
==========================================
+ Hits 30306 31705 +1399
+ Misses 10511 10483 -28 ☔ View full report in Codecov by Sentry. |
Playwright test resultsDetails Open report ↗︎ Flaky testsmsedge-setup › setup/unaffiliated.setup.ts › authenticate with unaffiliated user Skipped testschrome › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options |
throwIfBusinessError, | ||
} from "@/bricks/transformers/ai/domAiHelpers"; | ||
|
||
// Copied from @types/dom-chromium-ai because they're not exported |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we end up using this, we should open an issue/PR to export them. Probably an oversight by the maintainers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree -- issue would need to be opened here: https://github.com/DefinitelyTyped/DefinitelyTyped/discussions/new?category=issues-with-a-types-package
No loom links were found in the first post. Please add one there if you'd like to it to appear on Slack. Do not edit this comment manually. |
What does this PR do?
Discussion
Future Work
For more information on our expectations for the PR process, see the
code review principles doc