Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SandboxTimeoutError metadata to error message instead of extra properties #9262

Merged
merged 3 commits into from
Oct 10, 2024

Conversation

mnholtz
Copy link
Collaborator

@mnholtz mnholtz commented Oct 9, 2024

What does this PR do?

  • Part of [Spike] render_nunjucks error spike #9150
  • After adding additional error metadata in #9150 Additional sandbox TimeoutError logging and reinjection #9208, we realized that some of the additional metadata we added is getting striped by the Datadog vendor code. To avoid unnecessary complexity and time, I suggest that we add the additional metadata to the error message itself and move on.
  • For reviewer reference, I have debugged the issue and confirmed that it is the vendor code that is stripping the additional error properties. We also seem to be unable to call reportError from within this context directly

Copy link

github-actions bot commented Oct 10, 2024

Playwright test results

passed  136 passed
flaky  2 flaky
skipped  4 skipped

Details

report  Open report ↗︎
stats  142 tests across 46 suites
duration  12 minutes, 18 seconds
commit  e90e14f
info  For more information on how to debug and view this report, see our readme

Flaky tests

chrome › tests/pageEditor/addStarterBrick.spec.ts › Add starter brick to mod
msedge › tests/pageEditor/addStarterBrick.spec.ts › Add starter brick to mod

Skipped tests

chrome › tests/regressions/doNotCloseSidebarOnPageEditorSave.spec.ts › #8104: Do not automatically close the sidebar when saving in the Page Editor
msedge › tests/regressions/doNotCloseSidebarOnPageEditorSave.spec.ts › #8104: Do not automatically close the sidebar when saving in the Page Editor
chrome › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options
msedge › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options

@fungairino
Copy link
Collaborator

To follow-up with Datadog, I created this issue: DataDog/browser-sdk#3067

@fungairino
Copy link
Collaborator

We should consider modifying reportError / recordError to support any arbitrary additional context properties, similar to how we already support this in reportEvent.

@mnholtz
Copy link
Collaborator Author

mnholtz commented Oct 10, 2024

We should consider modifying reportError / recordError to support any arbitrary additional context properties, similar to how we already support this in reportEvent.

Agreed, although I'm not 100% sure how we'd design it in a situation like this where we want to add extra properties to a deeply nested error stack

@mnholtz
Copy link
Collaborator Author

mnholtz commented Oct 10, 2024

To follow-up with Datadog, I created this issue: DataDog/browser-sdk#3067

Great idea, thanks for doing that

Copy link

codecov bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.09%. Comparing base (8318d74) to head (e90e14f).
Report is 358 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9262      +/-   ##
==========================================
+ Coverage   74.24%   75.09%   +0.85%     
==========================================
  Files        1332     1369      +37     
  Lines       40817    42264    +1447     
  Branches     7634     7882     +248     
==========================================
+ Hits        30306    31740    +1434     
- Misses      10511    10524      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

No loom links were found in the first post. Please add one there if you'd like to it to appear on Slack.

Do not edit this comment manually.

@mnholtz mnholtz merged commit 786e594 into main Oct 10, 2024
23 checks passed
@mnholtz mnholtz deleted the bugfix/sandbox_timeout_error_additional_logging branch October 10, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants