-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#8933: adds mousedown handler to solve document mousedown handler bug #8931
Conversation
No loom links were found in the first post. Please add one there if you'd like to it to appear on Slack. Do not edit this comment manually. |
// In Chrome 127.0.6533.73, the `chrome.sidePanel.open()` API started throwing user gesture errors | ||
// when a message from the content script was sent to the background script. | ||
// The root cause appears to be a registered mousedown handler on the document that sends a message | ||
// Adding `mousedown` here ensures that the sidePanel.open call is made before the message for the mousedown | ||
// handler on the document is sent. | ||
// See https://issues.chromium.org/issues/355266358 for more details. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the detailed, concise explanation!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8931 +/- ##
==========================================
+ Coverage 74.24% 74.60% +0.35%
==========================================
Files 1332 1336 +4
Lines 40817 41202 +385
Branches 7634 7704 +70
==========================================
+ Hits 30306 30737 +431
+ Misses 10511 10465 -46 ☔ View full report in Codecov by Sentry. |
Playwright test resultsDetails Open report ↗︎ Flaky testsedge › tests/pageEditor/copyMod.spec.ts › run a copied mod with a built-in integration Skipped testschrome › tests/regressions/doNotCloseSidebarOnPageEditorSave.spec.ts › #8104: Do not automatically close the sidebar when saving in the Page Editor |
…#8931) * adds mousedown handler to solve document mousedown handler bug * explain the mousedown event
* fix this thing * wrap mutationobserver in feature flag * 8925: fix sidebar not being updated on deployment group membership removal (#8932) * fix sidebar not being updated on deployment group membership removal * skip test * #8933: adds mousedown handler to solve document mousedown handler bug (#8931) * adds mousedown handler to solve document mousedown handler bug * explain the mousedown event * Define report mode constants (#8926) * #8421: default sidebar to a panel for mod that set the badge (#8918) * Fix beta starter brick feature flag detection (#8929) * Prevent crash with `getContexts` and fix the window reference in `reportError` (#8934) * don't reference window from a background function * remove dangerous getContexts call from offscreen doc logic * fix logic issues * add some debug logs * cleanup * more specific version --------- Co-authored-by: Ben Loe <[email protected]> * add e2e test * remove page.pause in test * revert reportError noop * Rename flag, and change it to enable the hack. * switching to using jquery initialize * rename --------- Co-authored-by: Eduardo <[email protected]> Co-authored-by: Graham Langford <[email protected]> Co-authored-by: Todd Schiller <[email protected]> Co-authored-by: Ben Loe <[email protected]> Co-authored-by: Ben Loe <[email protected]>
* fix this thing * wrap mutationobserver in feature flag * 8925: fix sidebar not being updated on deployment group membership removal (#8932) * fix sidebar not being updated on deployment group membership removal * skip test * #8933: adds mousedown handler to solve document mousedown handler bug (#8931) * adds mousedown handler to solve document mousedown handler bug * explain the mousedown event * Define report mode constants (#8926) * #8421: default sidebar to a panel for mod that set the badge (#8918) * Fix beta starter brick feature flag detection (#8929) * Prevent crash with `getContexts` and fix the window reference in `reportError` (#8934) * don't reference window from a background function * remove dangerous getContexts call from offscreen doc logic * fix logic issues * add some debug logs * cleanup * more specific version --------- Co-authored-by: Ben Loe <[email protected]> * add e2e test * remove page.pause in test * revert reportError noop * Rename flag, and change it to enable the hack. * switching to using jquery initialize * rename --------- Co-authored-by: Eduardo <[email protected]> Co-authored-by: Graham Langford <[email protected]> Co-authored-by: Todd Schiller <[email protected]> Co-authored-by: Ben Loe <[email protected]> Co-authored-by: Ben Loe <[email protected]>
What does this PR do?
For more information on our expectations for the PR process, see the
code review principles doc