-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#8791: Migrate /api/me/ from version 1.0 to 1.1 #8793
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8793 +/- ##
==========================================
+ Coverage 74.24% 74.55% +0.30%
==========================================
Files 1332 1338 +6
Lines 40817 41290 +473
Branches 7634 7730 +96
==========================================
+ Hits 30306 30782 +476
+ Misses 10511 10508 -3 ☔ View full report in Codecov by Sentry. |
Playwright test results 8 failed Details Open report ↗︎ Failed testschrome › tests/extensionConsole/activation.spec.ts › can activate a mod with built-in integration Flaky testsedge › tests/regressions/welcomeStarterBricks.spec.ts › #8740: can view the starter mods on the pixiebrix.com/welcome page Skipped testschrome › tests/regressions/doNotCloseSidebarOnPageEditorSave.spec.ts › #8104: Do not automatically close the sidebar when saving in the Page Editor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like all the places where you are adding the me version header are using getApiClient()
, and also this is going to get messy if we start versioning every call site of every various endpoint like this. Should we start setting up an "API versioning" architecture within the api client where it attaches versioning headers based on match patterns for the request urls, or something like that that's more maintainable/extensible than manually adding the headers everywhere?
8f1588f
to
37e3e9a
Compare
2cdfdc0
to
36b1f6b
Compare
5e26621
to
a5f905b
Compare
6c6af89
to
e8c50ca
Compare
e8c50ca
to
b368303
Compare
b368303
to
65ae845
Compare
Closing in favor of #9074 b/c it's easier to start from scratch than resolve the merge conflicts |
What does this PR do?
isEnterprise
fieldDemo
https://www.loom.com/share/390fccf83dc34902a26490107d28f80c