Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#8607 Rename useAddElement -> useAddNewModComponent hook #8640

Merged
merged 10 commits into from
Jun 18, 2024

Conversation

mnholtz
Copy link
Collaborator

@mnholtz mnholtz commented Jun 17, 2024

What does this PR do?

Reviewer tips

  • Take a look at my commit messages for a quick summary of what I renamed

Checklist

  • Add jest or playwright tests and/or storybook stories - n/a
  • Designate a primary reviewer @BLoe

@mnholtz mnholtz requested review from BLoe and fungairino June 17, 2024 22:02

activateElement(state, element);
activateElement(state, modComponentFormState);
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I considered removing activateElement a side effect here, but I decided to stick purely to renaming as is the goal of this work.

@mnholtz mnholtz changed the title Feature/8607 rename element mod component form state #8607 Rename useAddElement -> useAddNewModComponent hook Jun 17, 2024
Copy link

codecov bot commented Jun 17, 2024

Codecov Report

Attention: Patch coverage is 59.45946% with 15 lines in your changes missing coverage. Please review.

Project coverage is 73.70%. Comparing base (c32e86f) to head (340c4d9).
Report is 1 commits behind head on main.

Files Patch % Lines
src/pageEditor/hooks/useAddNewModComponent.ts 8.33% 11 Missing ⚠️
src/pageEditor/panes/insert/useAutoInsert.ts 33.33% 2 Missing ⚠️
...geEditor/sidebar/ActivatedModComponentListItem.tsx 0.00% 1 Missing ⚠️
src/pageEditor/sidebar/AddStarterBrickButton.tsx 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8640   +/-   ##
=======================================
  Coverage   73.69%   73.70%           
=======================================
  Files        1344     1344           
  Lines       41566    41598   +32     
  Branches     7775     7780    +5     
=======================================
+ Hits        30633    30660   +27     
- Misses      10933    10938    +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jun 17, 2024

Playwright test results

passed  75 passed
skipped  2 skipped

Details

report  Open report ↗︎
stats  77 tests across 26 suites
duration  10 minutes, 46 seconds
commit  340c4d9

Skipped tests

chrome › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options
edge › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options

Copy link

No loom links were found in the first post. Please add one there if you'd like to it to appear on Slack.

Do not edit this comment manually.

@mnholtz mnholtz merged commit eb2ee7e into main Jun 18, 2024
19 checks passed
@mnholtz mnholtz deleted the feature/8607_rename_element_modComponentFormState branch June 18, 2024 00:33
@twschiller twschiller added this to the 2.0.3 milestone Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants