-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#8607 Rename useAddElement
-> useAddNewModComponent
hook
#8640
#8607 Rename useAddElement
-> useAddNewModComponent
hook
#8640
Conversation
|
||
activateElement(state, element); | ||
activateElement(state, modComponentFormState); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I considered removing activateElement
a side effect here, but I decided to stick purely to renaming as is the goal of this work.
useAddElement
-> useAddNewModComponent
hook
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8640 +/- ##
=======================================
Coverage 73.69% 73.70%
=======================================
Files 1344 1344
Lines 41566 41598 +32
Branches 7775 7780 +5
=======================================
+ Hits 30633 30660 +27
- Misses 10933 10938 +5 ☔ View full report in Codecov by Sentry. |
Playwright test resultsDetails Open report ↗︎ Skipped testschrome › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options |
No loom links were found in the first post. Please add one there if you'd like to it to appear on Slack. Do not edit this comment manually. |
What does this PR do?
useAddElement
hook ->useAddNewModComponent
hook and all dependency methods/typesReviewer tips
Checklist