-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#8600: drop deprecated localStorage
data binding for embedded forms
#8631
Conversation
localStorage
data bindinglocalStorage
data binding for embedded forms
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8631 +/- ##
==========================================
+ Coverage 73.63% 73.69% +0.05%
==========================================
Files 1344 1344
Lines 41544 41564 +20
Branches 7767 7773 +6
==========================================
+ Hits 30592 30630 +38
+ Misses 10952 10934 -18 ☔ View full report in Codecov by Sentry. |
Playwright test resultsDetails Open report ↗︎ Skipped testschrome › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options |
…rage-data-binding
Learning: How did you make the query you mentioned in the description? |
See https://app.pixiebrix.com/registry-query which has a linked Notion with examples. I had to use command line because the query was taking longer than 30s |
No loom links were found in the first post. Please add one there if you'd like to it to appear on Slack. Do not edit this comment manually. |
What does this PR do?
localStorage
data binding, including dropping the default value passed for "storage"storage
prop required on custom formDiscussion
@pixies/linkedin/organization-demos
which doesn't declare a storage type (that mod was hand-written in v1). We could switch that test mod to use mod variable, or just drop that part of the test. (I'd vote we just drop that part of the mod given we're not supporting that use case)Customer Impact Checks for Backward Compatibility
✅ Query:
$..*[?(@.type=="localStorage")]
No customer mods impacted
Future Work
Checklist