#8600: drop deprecated localStorage data binding for embedded forms

[twschiller]

What does this PR do?

• Closes Drop deprecated data location from embedded form #8600
• Drops deprecated localStorage data binding, including dropping the default value passed for "storage"
• Makes storage prop required on custom form
• Rewrite tests to use mod variables

Discussion

• The change is backward incompatible. The field had shown as Deprecated in the Page Editor for a long time
• Will break the inline panel in test mod @pixies/linkedin/organization-demos which doesn't declare a storage type (that mod was hand-written in v1). We could switch that test mod to use mod variable, or just drop that part of the test. (I'd vote we just drop that part of the mod given we're not supporting that use case)

Customer Impact Checks for Backward Compatibility

✅ Query: $..*[?(@.type=="localStorage")]

No customer mods impacted

Future Work

• There's some future improvements we'll need to make. Custom form doesn't use the Platform API for mod variables, it calls the content script messenger directly

Checklist

• Add jest or playwright tests and/or storybook stories
• Designate a primary reviewer: @fungairino

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.69%. Comparing base (18c5348) to head (1c3b83b).
Report is 31 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8631      +/-   ##
==========================================
+ Coverage   73.63%   73.69%   +0.05%     
==========================================
  Files        1344     1344              
  Lines       41544    41564      +20     
  Branches     7767     7773       +6     
==========================================
+ Hits        30592    30630      +38     
+ Misses      10952    10934      -18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

Playwright test results

 75 passed
 2 skipped

Details

 Open report ↗︎
 77 tests across 26 suites
 10 minutes, 46 seconds
 1c3b83b

Skipped tests

chrome › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options
edge › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options

[fungairino]

Learning:

How did you make the query you mentioned in the description?
"$..*[?(@.type=="localStorage")]"

[twschiller]

Learning:

How did you make the query you mentioned in the description? "$..*[?(@.type=="localStorage")]"

See https://app.pixiebrix.com/registry-query which has a linked Notion with examples. I had to use command line because the query was taking longer than 30s

[github-actions]

No loom links were found in the first post. Please add one there if you'd like to it to appear on Slack.

Do not edit this comment manually.