#7211: Use ESM in webpack config #7212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7212 +/- ##
=======================================
Coverage 71.39% 71.39%
=======================================
Files 1211 1211
Lines 37776 37776
Branches 7100 7100
=======================================
Hits 26971 26971
Misses 10805 10805 ☔ View full report in Codecov by Sentry. |
twschiller
approved these changes
Dec 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
I ran into the usual ESM issues in the previous PR (#7211 (comment)), I thought it might be easier to just switch more files to ESM instead. Thankfully it was pretty straightforward 😮💨
Switching to .ts is harder/more involved: swc-project/register#12
Checklist