Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLACEHOLDER: focus dialog always required in Chrome 127 and click doesn't open sidebar #8933

Closed
twschiller opened this issue Jul 26, 2024 · 3 comments
Assignees
Labels
blocked For denoting when an issue is blocked by an external dependency (ex. zendesk) regression user experience Improve the user experience (UX)

Comments

@twschiller
Copy link
Contributor

twschiller commented Jul 26, 2024

Context

@twschiller twschiller changed the title PLACEHOLDER: focus dialog always shows and click doesn't open sidebar PLACEHOLDER: focus dialog always required and click doesn't open sidebar Jul 26, 2024
grahamlangford added a commit that referenced this issue Jul 26, 2024
…#8931)

* adds mousedown handler to solve document mousedown handler bug

* explain the mousedown event
fungairino pushed a commit that referenced this issue Jul 26, 2024
…#8931)

* adds mousedown handler to solve document mousedown handler bug

* explain the mousedown event
@twschiller twschiller changed the title PLACEHOLDER: focus dialog always required and click doesn't open sidebar PLACEHOLDER: focus dialog always required in Chrome 127 and click doesn't open sidebar Jul 27, 2024
@twschiller twschiller added user experience Improve the user experience (UX) regression labels Jul 27, 2024
fungairino added a commit that referenced this issue Jul 29, 2024
* fix this thing

* wrap mutationobserver in feature flag

* 8925: fix sidebar not being updated on deployment group membership removal (#8932)

* fix sidebar not being updated on deployment group membership removal

* skip test

* #8933: adds mousedown handler to solve document mousedown handler bug (#8931)

* adds mousedown handler to solve document mousedown handler bug

* explain the mousedown event

* Define report mode constants (#8926)

* #8421: default sidebar to a panel for mod that set the badge (#8918)

* Fix beta starter brick feature flag detection (#8929)

* Prevent crash with `getContexts` and fix the window reference in `reportError` (#8934)

* don't reference window from a background function

* remove dangerous getContexts call from offscreen doc logic

* fix logic issues

* add some debug logs

* cleanup

* more specific version

---------

Co-authored-by: Ben Loe <[email protected]>

* add e2e test

* remove page.pause in test

* revert reportError noop

* Rename flag, and change it to enable the hack.

* switching to using jquery initialize

* rename

---------

Co-authored-by: Eduardo <[email protected]>
Co-authored-by: Graham Langford <[email protected]>
Co-authored-by: Todd Schiller <[email protected]>
Co-authored-by: Ben Loe <[email protected]>
Co-authored-by: Ben Loe <[email protected]>
grahamlangford added a commit that referenced this issue Jul 29, 2024
* fix this thing

* wrap mutationobserver in feature flag

* 8925: fix sidebar not being updated on deployment group membership removal (#8932)

* fix sidebar not being updated on deployment group membership removal

* skip test

* #8933: adds mousedown handler to solve document mousedown handler bug (#8931)

* adds mousedown handler to solve document mousedown handler bug

* explain the mousedown event

* Define report mode constants (#8926)

* #8421: default sidebar to a panel for mod that set the badge (#8918)

* Fix beta starter brick feature flag detection (#8929)

* Prevent crash with `getContexts` and fix the window reference in `reportError` (#8934)

* don't reference window from a background function

* remove dangerous getContexts call from offscreen doc logic

* fix logic issues

* add some debug logs

* cleanup

* more specific version

---------

Co-authored-by: Ben Loe <[email protected]>

* add e2e test

* remove page.pause in test

* revert reportError noop

* Rename flag, and change it to enable the hack.

* switching to using jquery initialize

* rename

---------

Co-authored-by: Eduardo <[email protected]>
Co-authored-by: Graham Langford <[email protected]>
Co-authored-by: Todd Schiller <[email protected]>
Co-authored-by: Ben Loe <[email protected]>
Co-authored-by: Ben Loe <[email protected]>
@twschiller twschiller added the blocked For denoting when an issue is blocked by an external dependency (ex. zendesk) label Jul 29, 2024
@grahamlangford
Copy link
Collaborator

Update: Chrome Canary has a fix. I've installed and tested and confirmed it solves our user gesture issues.

The Chromium team says they will attempt to backport the fix to Chrome 128, but it is unlikely to be applied to Chrome 127

@twschiller
Copy link
Contributor Author

@grahamlangford can we close out given that 128 is coming out this week?

@grahamlangford
Copy link
Collaborator

Chromium team has resolved this issue in Chrome 128

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked For denoting when an issue is blocked by an external dependency (ex. zendesk) regression user experience Improve the user experience (UX)
Projects
None yet
Development

No branches or pull requests

2 participants