Skip to content

Commit

Permalink
Rename panel/side panel to match starter brick naming conventions (#8659
Browse files Browse the repository at this point in the history
)
  • Loading branch information
twschiller authored Jun 21, 2024
1 parent 209ab24 commit ebc39a7
Show file tree
Hide file tree
Showing 14 changed files with 139 additions and 136 deletions.
4 changes: 2 additions & 2 deletions src/components/BrickIcon.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,8 @@ import {
import { TriggerStarterBrickABC } from "@/starterBricks/trigger/triggerStarterBrick";
import { MenuItemStarterBrickABC } from "@/starterBricks/menuItem/menuItemStarterBrick";
import { ContextMenuStarterBrickABC } from "@/starterBricks/contextMenu/contextMenu";
import { PanelStarterBrickABC } from "@/starterBricks/panel/panelExtension";
import { SidebarStarterBrickABC } from "@/starterBricks/sidebar/sidebarExtension";
import { PanelStarterBrickABC } from "@/starterBricks/panel/panelStarterBrick";
import { SidebarStarterBrickABC } from "@/starterBricks/sidebar/sidebarStarterBrick";
import getType from "@/runtime/getType";
import { type BrickType } from "@/runtime/runtimeTypes";
import { type Metadata } from "@/types/registryTypes";
Expand Down
4 changes: 2 additions & 2 deletions src/contentScript/lifecycle.ts
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ import { type UUID } from "@/types/stringTypes";
import { type RegistryId } from "@/types/registryTypes";
import { RunReason } from "@/types/runtimeTypes";
import { type ResolvedModComponent } from "@/types/modComponentTypes";
import { type SidebarStarterBrickABC } from "@/starterBricks/sidebar/sidebarExtension";
import { type SidebarStarterBrickABC } from "@/starterBricks/sidebar/sidebarStarterBrick";
import {
getReloadOnNextNavigate,
setReloadOnNextNavigate,
Expand Down Expand Up @@ -293,7 +293,7 @@ export function clearEditorExtension(

if (extensionPoint.kind === "actionPanel" && preserveSidebar) {
const sidebar = extensionPoint as SidebarStarterBrickABC;
sidebar.HACK_uninstallExceptExtension(extensionId);
sidebar.HACK_uninstallExceptModComponent(extensionId);
} else {
extensionPoint.uninstall({ global: true });
}
Expand Down
2 changes: 1 addition & 1 deletion src/contentScript/pageEditor/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ import { type Except } from "type-fest";
import {
type PanelConfig,
type PanelDefinition,
} from "@/starterBricks/panel/types";
} from "@/starterBricks/panel/panelStarterBrickTypes";
import {
type MenuItemDefinition,
type MenuItemStarterBrickConfig,
Expand Down
4 changes: 2 additions & 2 deletions src/pageEditor/starterBricks/formStateTypes.ts
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ import {
type MenuItemStarterBrickConfig,
type MenuPosition,
} from "@/starterBricks/menuItem/menuItemTypes";
import { type PanelConfig } from "@/starterBricks/panel/types";
import { type PanelConfig } from "@/starterBricks/panel/panelStarterBrickTypes";
import {
type QuickBarConfig,
type QuickBarDefaultOptions,
Expand All @@ -34,7 +34,7 @@ import {
import {
type SidebarConfig,
type Trigger as SidebarTrigger,
} from "@/starterBricks/sidebar/types";
} from "@/starterBricks/sidebar/sidebarStarterBrickTypes";
import {
type AttachMode,
type ReportMode,
Expand Down
4 changes: 2 additions & 2 deletions src/pageEditor/starterBricks/panel.ts
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ import {
} from "@/pageEditor/starterBricks/base";
import { omitEditorMetadata } from "./pipelineMapping";
import { type StarterBrickDefinitionLike } from "@/starterBricks/types";
import { PanelStarterBrickABC } from "@/starterBricks/panel/panelExtension";
import { PanelStarterBrickABC } from "@/starterBricks/panel/panelStarterBrick";
import { getDomain } from "@/permissions/patterns";
import { faWindowMaximize } from "@fortawesome/free-solid-svg-icons";
import { type ModComponentFormStateAdapter } from "@/pageEditor/starterBricks/modComponentFormStateAdapter";
Expand All @@ -46,7 +46,7 @@ import { type PanelFormState, type PanelTraits } from "./formStateTypes";
import {
type PanelDefinition,
type PanelConfig,
} from "@/starterBricks/panel/types";
} from "@/starterBricks/panel/panelStarterBrickTypes";
import { assertNotNullish } from "@/utils/nullishUtils";

const DEFAULT_TRAITS: PanelTraits = {
Expand Down
4 changes: 2 additions & 2 deletions src/pageEditor/starterBricks/sidebar.ts
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ import {
} from "@/pageEditor/starterBricks/base";
import { omitEditorMetadata } from "./pipelineMapping";
import { type StarterBrickDefinitionLike } from "@/starterBricks/types";
import { SidebarStarterBrickABC } from "@/starterBricks/sidebar/sidebarExtension";
import { SidebarStarterBrickABC } from "@/starterBricks/sidebar/sidebarStarterBrick";
import { getDomain } from "@/permissions/patterns";
import { faColumns } from "@fortawesome/free-solid-svg-icons";
import SidebarConfiguration from "@/pageEditor/tabs/sidebar/SidebarConfiguration";
Expand All @@ -42,7 +42,7 @@ import { type SidebarFormState } from "./formStateTypes";
import {
type SidebarConfig,
type SidebarDefinition,
} from "@/starterBricks/sidebar/types";
} from "@/starterBricks/sidebar/sidebarStarterBrickTypes";
import { assertNotNullish } from "@/utils/nullishUtils";

function fromNativeElement(url: string, metadata: Metadata): SidebarFormState {
Expand Down
2 changes: 1 addition & 1 deletion src/pageEditor/tabs/sidebar/SidebarConfiguration.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ import { makeLockableFieldProps } from "@/pageEditor/fields/makeLockableFieldPro
import MatchRulesSection from "@/pageEditor/tabs/MatchRulesSection";
import { partial } from "lodash";
import DebounceFieldSet from "@/pageEditor/tabs/trigger/DebounceFieldSet";
import { type Trigger } from "@/starterBricks/sidebar/types";
import { type Trigger } from "@/starterBricks/sidebar/sidebarStarterBrickTypes";
import { useField, useFormikContext } from "formik";
import { type TriggerFormState } from "@/pageEditor/starterBricks/formStateTypes";
import { type DebounceOptions } from "@/starterBricks/types";
Expand Down
4 changes: 2 additions & 2 deletions src/starterBricks/factory.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,11 @@
* along with this program. If not, see <http://www.gnu.org/licenses/>.
*/

import { fromJS as deserializePanel } from "@/starterBricks/panel/panelExtension";
import { fromJS as deserializePanel } from "@/starterBricks/panel/panelStarterBrick";
import { fromJS as deserializeMenuItem } from "@/starterBricks/menuItem/menuItemStarterBrick";
import { fromJS as deserializeTrigger } from "@/starterBricks/trigger/triggerStarterBrick";
import { fromJS as deserializeContextMenu } from "@/starterBricks/contextMenu/contextMenu";
import { fromJS as deserializeSidebar } from "@/starterBricks/sidebar/sidebarExtension";
import { fromJS as deserializeSidebar } from "@/starterBricks/sidebar/sidebarStarterBrick";
import { fromJS as deserializeQuickBar } from "@/starterBricks/quickBar/quickBarStarterBrick";
import { fromJS as deserializeQuickBarProvider } from "@/starterBricks/quickBarProvider/quickBarProviderStarterBrick";
import { fromJS as deserializeTour } from "@/starterBricks/tour/tourExtension";
Expand Down
Loading

0 comments on commit ebc39a7

Please sign in to comment.