Drop unused FormState.optionsDefinition property and related code (#…

…9312)
pixiebrix · Oct 21, 2024 · e85974b · e85974b
1 parent a4efa1d
commit e85974b
Show file tree

Hide file tree

Showing 10 changed files with 17 additions and 966 deletions.
diff --git a/src/pageEditor/hooks/useClearModComponentChanges.ts b/src/pageEditor/hooks/useClearModComponentChanges.ts
@@ -21,13 +21,11 @@ import { useModals } from "@/components/ConfirmationModal";
 import { useCallback } from "react";
 import { modComponentToFormState } from "@/pageEditor/starterBricks/adapter";
 import reportError from "@/telemetry/reportError";
-import { initModOptionsIfNeeded } from "@/pageEditor/starterBricks/base";
 import { selectSessionId } from "@/pageEditor/store/session/sessionSelectors";
 import reportEvent from "@/telemetry/reportEvent";
 import { Events } from "@/telemetry/events";
 import { type UUID } from "@/types/stringTypes";
 import { useAllModDefinitions } from "@/modDefinitions/modDefinitionHooks";
-import { compact } from "lodash";
 
 import { selectActivatedModComponents } from "@/store/modComponents/modComponentSelectors";
 
@@ -79,7 +77,6 @@ function useClearModComponentChanges(): (
           const formState = await modComponentToFormState(
             activatedModComponent,
           );
-          initModOptionsIfNeeded(formState, compact(mods));
           dispatch(actions.resetActivatedModComponentFormState(formState));
         }
       } catch (error) {

diff --git a/src/pageEditor/modListingPanel/ActivatedModComponentListItem.tsx b/src/pageEditor/modListingPanel/ActivatedModComponentListItem.tsx
@@ -47,8 +47,6 @@ import {
 import { type UUID } from "@/types/stringTypes";
 import { type ModComponentBase } from "@/types/modComponentTypes";
 import { appApi } from "@/data/service/api";
-import { emptyModOptionsDefinitionFactory } from "@/utils/modUtils";
-import { type Schema } from "@/types/schemaTypes";
 import useAsyncState from "@/hooks/useAsyncState";
 import { inspectedTab } from "@/pageEditor/context/connection";
 import { StarterBrickTypes } from "@/types/starterBrickTypes";
@@ -93,26 +91,6 @@ const ActivatedModComponentListItem: React.FunctionComponent<{
         const modComponentFormState =
           await modComponentToFormState(modComponent);
 
-        // Initialize mod options schema if needed
-        const { data: modDefinition } = await getModDefinition(
-          { modId: modComponent.modMetadata.id },
-          true,
-        );
-        if (modDefinition) {
-          modComponentFormState.optionsDefinition =
-            modDefinition.options == null
-              ? emptyModOptionsDefinitionFactory()
-              : {
-                  schema: modDefinition.options.schema.properties
-                    ? modDefinition.options.schema
-                    : ({
-                        type: "object",
-                        properties: modDefinition.options.schema,
-                      } as Schema),
-                  uiSchema: modDefinition.options.uiSchema,
-                };
-        }
-
         dispatch(
           actions.selectActivatedModComponentFormState(modComponentFormState),
         );