fixes

pixiebrix · Jun 10, 2024 · a81e3ac · a81e3ac
1 parent 96e731b
commit a81e3ac
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -293,6 +293,6 @@ jobs:
         uses: daun/playwright-report-summary@v3
         with:
           comment-title: "Playwright test results"
-          report-file: ${{ steps.upload-merged-playwright-report-step.outputs.artifact-url }}
-          report-url: https://github.com/pixiebrix/pixiebrix-extension/actions/runs/${{ github.run_id }}
+          report-file: ./playwright-report/results.json
+          report-url: ${{ steps.upload-merged-playwright-report-step.outputs.artifact-url }}
         if: (success() || failure()) && github.event_name == 'pull_request'
diff --git a/end-to-end-tests/pageObjects/external/googleAuthPopup.ts b/end-to-end-tests/pageObjects/external/googleAuthPopup.ts
@@ -39,8 +39,7 @@ const submitOtpCode = async (googleAuthPopup: Page) => {
 
   await expect(async () => {
     await enterCode.click();
-    // eslint-disable-next-line @typescript-eslint/no-non-null-assertion -- checked before this call
-    const otpKey = E2E_GOOGLE_TEST_USER_OTP_KEY!.replaceAll(/\s/g, "");
+    const otpKey = E2E_GOOGLE_TEST_USER_OTP_KEY.replaceAll(/\s/g, "");
     const token = generateOTP(otpKey);
     expect(token).not.toStrictEqual(prevToken); // Ensure the token is different from the previous one on retry
     prevToken = token;