Skip to content

Commit

Permalink
Implement knip production mode in CI (#9330)
Browse files Browse the repository at this point in the history
* revert deletion of react-virtualized

* document react-virtualized

* refactor knip.mjs

* delete knip.production.mjs

* adds missing dep from lockfile

* improved project exclude comment

* delete or comment dead production code

* handle more files

* wip

* finish marking kept files @internal

* delete duplicates from bad merge

* another merge fix

* delete more dead code

* more dead code deletion

* implement the dead code check in ci

* wip

* fix bad merge
  • Loading branch information
grahamlangford authored Oct 22, 2024
1 parent 1f3d406 commit 828f4d4
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
2 changes: 2 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -177,6 +177,8 @@ jobs:
- run: npm ci
# Detect dead code with enforced rules
- run: npm run dead-code
# Detect dead code that is only used by tests
- run: npm run dead-code:prod
# Also run the remaining "warn" rules
- run: npm run dead-code:base -- --no-exit-code

Expand Down
4 changes: 2 additions & 2 deletions .secrets.baseline
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@
"filename": ".github/workflows/ci.yml",
"hashed_secret": "3e26d6750975d678acb8fa35a0f69237881576b0",
"is_verified": false,
"line_number": 196
"line_number": 198
}
],
".github/workflows/e2e-test-pre-release-browsers.yml": [
Expand Down Expand Up @@ -273,5 +273,5 @@
}
]
},
"generated_at": "2024-10-21T20:51:16Z"
"generated_at": "2024-10-22T20:32:58Z"
}

0 comments on commit 828f4d4

Please sign in to comment.