#9323: deduplicate Page Editor save helpers (2/2) (#9332)

pixiebrix · Oct 23, 2024 · 739aab9 · 739aab9
1 parent 945c24a
commit 739aab9
Show file tree

Hide file tree

Showing 46 changed files with 1,067 additions and 1,470 deletions.
diff --git a/...rterBrick.spec.ts-snapshots/Add-starter-brick-to-mod/add-button-starter-brick-to-mod.yaml b/...rterBrick.spec.ts-snapshots/Add-starter-brick-to-mod/add-button-starter-brick-to-mod.yaml
@@ -21,7 +21,7 @@ definitions:
   extensionPoint:
     kind: extensionPoint
     definition:
-      type: trigger
+      type: menuItem
       reader:
         - '@pixiebrix/document-metadata'
         - '@pixiebrix/document-context'
@@ -32,14 +32,15 @@ definitions:
         urlPatterns: []
         selectors: []
         allFrames: true
-      trigger: load
-      background: true
-      reportMode: once
-      showErrors: true
+      containerSelector: ul:has(> * > a:contains('navigation'))
+      targetMode: document
+      attachMode: once
+      position: append
+      template: <li><a href="#">{{{ caption }}}</a></li>
   extensionPoint2:
     kind: extensionPoint
     definition:
-      type: menuItem
+      type: trigger
       reader:
         - '@pixiebrix/document-metadata'
         - '@pixiebrix/document-context'
@@ -50,17 +51,11 @@ definitions:
         urlPatterns: []
         selectors: []
         allFrames: true
-      containerSelector: ul:has(> * > a:contains('navigation'))
-      targetMode: document
-      attachMode: once
-      position: append
-      template: <li><a href="#">{{{ caption }}}</a></li>
+      trigger: load
+      background: true
+      reportMode: once
+      showErrors: true
 extensionPoints:
-  - label: My pbx.vercel.app trigger
-    config:
-      action: []
-    id: extensionPoint
-    services: {}
   - label: My pbx.vercel.app button
     config:
       caption: Action
@@ -71,5 +66,13 @@ extensionPoints:
     permissions:
       origins: []
       permissions: []
+    id: extensionPoint
+    services: {}
+  - label: My pbx.vercel.app trigger
+    config:
+      action: []
+    permissions:
+      origins: []
+      permissions: []
     id: extensionPoint2
     services: {}
diff --git a/...ick.spec.ts-snapshots/Add-starter-brick-to-mod/add-context-menu-starter-brick-to-mod.diff b/...ick.spec.ts-snapshots/Add-starter-brick-to-mod/add-context-menu-starter-brick-to-mod.diff
@@ -2,86 +2,95 @@ Index: add-context-menu-starter-brick-to-mod
 ===================================================================
 --- add-context-menu-starter-brick-to-mod
 +++ add-context-menu-starter-brick-to-mod
-@@ -1,75 +1,101 @@
+@@ -1,78 +1,107 @@
  apiVersion: v3
  definitions:
    extensionPoint:
      definition:
-       background: true
++      contexts:
++        - all
++      documentUrlPatterns:
++        - '*://*/*'
++      isAvailable:
++        allFrames: true
++        matchPatterns:
++          - '*://*/*'
++        selectors: []
++        urlPatterns: []
++      reader:
++        - '@pixiebrix/document-metadata'
++        - '@pixiebrix/document-context'
++        - element: '@pixiebrix/html/element'
++      targetMode: eventTarget
++      type: contextMenu
++    kind: extensionPoint
++  extensionPoint2:
++    definition:
+       attachMode: once
+       containerSelector: ul:has(> * > a:contains('navigation'))
        isAvailable:
          allFrames: true
          matchPatterns:
            - https://pbx.vercel.app/*
          selectors: []
          urlPatterns: []
+       position: append
        reader:
          - '@pixiebrix/document-metadata'
          - '@pixiebrix/document-context'
          - element: '@pixiebrix/html/element'
-       reportMode: once
-       showErrors: true
-       trigger: load
-       type: trigger
+       targetMode: document
+       template: <li><a href="#">{{{ caption }}}</a></li>
+       type: menuItem
      kind: extensionPoint
-   extensionPoint2:
+-  extensionPoint2:
++  extensionPoint5:
      definition:
-       attachMode: once
-       containerSelector: ul:has(> * > a:contains('navigation'))
+       background: true
        isAvailable:
          allFrames: true
          matchPatterns:
            - https://pbx.vercel.app/*
          selectors: []
          urlPatterns: []
-       position: append
        reader:
          - '@pixiebrix/document-metadata'
          - '@pixiebrix/document-context'
          - element: '@pixiebrix/html/element'
-       targetMode: document
-       template: <li><a href="#">{{{ caption }}}</a></li>
-       type: menuItem
+       reportMode: once
+       showErrors: true
+       trigger: load
+       type: trigger
      kind: extensionPoint
-+  extensionPoint3:
-+    definition:
-+      contexts:
-+        - all
-+      documentUrlPatterns:
-+        - '*://*/*'
-+      isAvailable:
-+        allFrames: true
-+        matchPatterns:
-+          - '*://*/*'
-+        selectors: []
-+        urlPatterns: []
-+      reader:
-+        - '@pixiebrix/document-metadata'
-+        - '@pixiebrix/document-context'
-+        - element: '@pixiebrix/html/element'
-+      targetMode: eventTarget
-+      type: contextMenu
-+    kind: extensionPoint
  extensionPoints:
    - config:
        action: []
-     id: extensionPoint
-     label: My pbx.vercel.app trigger
-     services: {}
-   - config:
-       action: []
++      onSuccess: true
++      title: Context menu item
++    id: extensionPoint
++    label: Context menu item
++    permissions:
++      origins: []
++      permissions: []
++    services: {}
++  - config:
++      action: []
        caption: Action
        dynamicCaption: false
        onSuccess: true
        synchronous: false
-     id: extensionPoint2
+-    id: extensionPoint
++    id: extensionPoint2
      label: My pbx.vercel.app button
-+    services: {}
-+  - config:
-+      action: []
-+      onSuccess: true
-+      title: Context menu item
-+    id: extensionPoint3
-+    label: Context menu item
+     permissions:
+       origins: []
+       permissions: []
+     services: {}
+   - config:
+       action: []
+-    id: extensionPoint2
++    id: extensionPoint5
+     label: My pbx.vercel.app trigger
      permissions:
        origins: []
        permissions: []

diff --git a/...rBrick.spec.ts-snapshots/Add-starter-brick-to-mod/add-quick-bar-starter-brick-to-mod.diff b/...rBrick.spec.ts-snapshots/Add-starter-brick-to-mod/add-quick-bar-starter-brick-to-mod.diff
@@ -2,48 +2,48 @@ Index: add-quick-bar-starter-brick-to-mod
 ===================================================================
 --- add-quick-bar-starter-brick-to-mod
 +++ add-quick-bar-starter-brick-to-mod
-@@ -19,83 +19,109 @@
-       type: trigger
-     kind: extensionPoint
-   extensionPoint2:
+@@ -1,107 +1,136 @@
+ apiVersion: v3
+ definitions:
+   extensionPoint:
      definition:
-       attachMode: once
-       containerSelector: ul:has(> * > a:contains('navigation'))
+       contexts:
+         - all
+       documentUrlPatterns:
+         - '*://*/*'
        isAvailable:
          allFrames: true
          matchPatterns:
-           - https://pbx.vercel.app/*
+           - '*://*/*'
          selectors: []
          urlPatterns: []
-       position: append
        reader:
          - '@pixiebrix/document-metadata'
          - '@pixiebrix/document-context'
          - element: '@pixiebrix/html/element'
-       targetMode: document
-       template: <li><a href="#">{{{ caption }}}</a></li>
-       type: menuItem
+       targetMode: eventTarget
+       type: contextMenu
      kind: extensionPoint
-   extensionPoint3:
+   extensionPoint2:
      definition:
-       contexts:
-         - all
-       documentUrlPatterns:
-         - '*://*/*'
+       attachMode: once
+       containerSelector: ul:has(> * > a:contains('navigation'))
        isAvailable:
          allFrames: true
          matchPatterns:
-           - '*://*/*'
+           - https://pbx.vercel.app/*
          selectors: []
          urlPatterns: []
+       position: append
        reader:
          - '@pixiebrix/document-metadata'
          - '@pixiebrix/document-context'
          - element: '@pixiebrix/html/element'
-       targetMode: eventTarget
-       type: contextMenu
+       targetMode: document
+       template: <li><a href="#">{{{ caption }}}</a></li>
+       type: menuItem
      kind: extensionPoint
-+  extensionPoint4:
++  extensionPoint3:
 +    definition:
 +      contexts:
 +        - all
@@ -63,11 +63,34 @@ Index: add-quick-bar-starter-brick-to-mod
 +      targetMode: eventTarget
 +      type: quickBar
 +    kind: extensionPoint
+   extensionPoint5:
+     definition:
+       background: true
+       isAvailable:
+         allFrames: true
+         matchPatterns:
+           - https://pbx.vercel.app/*
+         selectors: []
+         urlPatterns: []
+       reader:
+         - '@pixiebrix/document-metadata'
+         - '@pixiebrix/document-context'
+         - element: '@pixiebrix/html/element'
+       reportMode: once
+       showErrors: true
+       trigger: load
+       type: trigger
+     kind: extensionPoint
  extensionPoints:
    - config:
        action: []
+       onSuccess: true
+       title: Context menu item
      id: extensionPoint
-     label: My pbx.vercel.app trigger
+     label: Context menu item
+     permissions:
+       origins: []
+       permissions: []
      services: {}
    - config:
        action: []
@@ -77,23 +100,27 @@ Index: add-quick-bar-starter-brick-to-mod
        synchronous: false
      id: extensionPoint2
      label: My pbx.vercel.app button
+     permissions:
+       origins: []
+       permissions: []
      services: {}
    - config:
        action: []
-       onSuccess: true
-       title: Context menu item
-     id: extensionPoint3
-     label: Context menu item
-+    services: {}
-+  - config:
-+      action: []
-+      title: Quick Bar item
-+    id: extensionPoint4
-+    label: Quick Bar item
+     id: extensionPoint5
+     label: My pbx.vercel.app trigger
      permissions:
        origins: []
        permissions: []
      services: {}
++  - config:
++      action: []
++      title: Quick Bar item
++    id: extensionPoint3
++    label: Quick Bar item
++    permissions:
++      origins: []
++      permissions: []
++    services: {}
  kind: recipe
  metadata:
    description: Created by playwright test for adding starter bricks to a mod