Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds CfConfigClientProcessor to load config-server oauth properties #198

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

kvmw
Copy link
Contributor

@kvmw kvmw commented Dec 22, 2022

Supports config-server OAuth2 properties in CF/TAS environment. OAuth2 support is in place for service-registry but not for config-server.
The primary consumer of these properties would be spring-cloud-config-starters which is currently unable to load configuration resource files due to missing oauth2 credentials.

@anthonydahanne
Copy link
Member

Hello @kvmw !
Does this PR still make sense?
I'm asking because pivotal-cf/spring-cloud-services-starters#323 was merged and seems to cover the same ground

@kvmw
Copy link
Contributor Author

kvmw commented Sep 19, 2023

Hello @kvmw ! Does this PR still make sense? I'm asking because pivotal-cf/spring-cloud-services-starters#323 was merged and seems to cover the same ground

Hi @anthonydahanne ,
Yes, It would be nice to have it in this library. The change in scs-starters is just a temporary one until this PR get merged.

@kvmw kvmw force-pushed the kvmw/config-server-env-processor branch from 4b8fa6e to 3ad3177 Compare August 13, 2024 14:25
@kvmw kvmw force-pushed the kvmw/config-server-env-processor branch from 3ad3177 to 8378bd4 Compare August 13, 2024 14:26
@kvmw
Copy link
Contributor Author

kvmw commented Aug 13, 2024

@anthonydahanne This is ready now!

@anthonydahanne anthonydahanne merged commit 3466053 into main Aug 13, 2024
1 check passed
@anthonydahanne anthonydahanne deleted the kvmw/config-server-env-processor branch August 13, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants