Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct file argument name in KeyedVectors.save docstring #3532

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

hammad7
Copy link
Contributor

@hammad7 hammad7 commented May 27, 2024

Fixes issue : #3528

Just a documentation update for filename argument for KeyedVectors.save() . The argument wasn't updated in the docs when it was changed in the parent class utils.SaveLoad from fname to fname_or_handle . Tested with code:

from gensim.models import KeyedVectors

# Create a KeyedVectors object
model = KeyedVectors(100)

# Attempt to save the model using the incorrect parameter name
try:
    model.save(fname_or_handle="my_model.kv")  ### fname gives error
except TypeError as e:
    print(e)

@mpenkov mpenkov added this to the Summer 2024 release milestone Jun 11, 2024
@piskvorky piskvorky added the documentation Current issue related to documentation label Jun 11, 2024
@piskvorky piskvorky changed the title Issue-3528: Corrected file argument name in KeyedVectors.save Correct file argument name in KeyedVectors.save Jun 11, 2024
@piskvorky piskvorky changed the title Correct file argument name in KeyedVectors.save Correct file argument name in KeyedVectors.save docstring Jun 11, 2024
@piskvorky piskvorky merged commit caeca0c into piskvorky:develop Jun 11, 2024
32 checks passed
@mpenkov
Copy link
Collaborator

mpenkov commented Jun 11, 2024

Thank you @hammad7 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Current issue related to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants