Apply group tab title correctly

piroor · Oct 4, 2020 · 93a822f · 93a822f
1 parent 2ac7109
commit 93a822f
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/webextensions/resources/group-tab.js b/webextensions/resources/group-tab.js
@@ -34,10 +34,11 @@
   function getTitle() {
     let title = params.get('title');
     if (!title) {
-      title = location.search.match(/^\?([^&;]*)/);
+      const matched = location.search.match(/^\?([^&;]*)/);
+      if (matched)
+        title = decodeURIComponent(matched[1]);
     }
-    return title && decodeURIComponent(title[1]) ||
-             browser.i18n.getMessage('groupTab_label_default');
+    return title || browser.i18n.getMessage('groupTab_label_default');
   }
 
   function setTitle(title) {