update golinstor to fix caching issue #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The golinstor caching implementation did not filter by properties, which is used by the NodesForTopology() call to filter the nodes based on properties. This meant that in some scenarios, LINSTOR CSI would place volumes on unexpected nodes, as it got the full list of nodes instead of one filtered to just some property. Signed-off-by: Moritz Wanzenböck <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The golinstor caching implementation did not filter by properties, which is used by the NodesForTopology() call to filter the nodes based on properties.
This meant that in some scenarios, LINSTOR CSI would place volumes on unexpected nodes, as it got the full list of nodes instead of one filtered to just some property.