implement deletion of local snapshots for S3 backups #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rck
requested changes
Jun 15, 2023
pkg/driver/driver.go
Outdated
| @@ -967,6 +976,14 @@ func (d Driver) CreateSnapshot(ctx context.Context, req *csi.CreateSnapshotReque | |||
| return nil, status.Errorf(codes.Internal, "failed to create snapshot: %v", err) | |||
| } | |||
|
|
|||
| if snap.ReadyToUse && params.Type != volume.SnapshotTypeInCluster && params.DeleteLocal { | |||
There was a problem hiding this comment.
this whole block is basically a copy from above. please make that a function; at least the check.
There was a problem hiding this comment.
Good point, moved to a function and cleaned it up a bit.
WanzenBug
force-pushed
the
delete-local-snapshots
branch
2 times, most recently
from
60f3698
to
4671200
Compare
When creating a remote backup in LINSTOR, we can remove the local snapshot after shipping completes. Signed-off-by: Moritz "WanzenBug" Wanzenböck <[email protected]>
WanzenBug
force-pushed
the
delete-local-snapshots
branch
from
4671200
to
c3b979f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating a remote backup in LINSTOR, we can remove the local snapshot after shipping completes.