implement deletion for backups #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WanzenBug
force-pushed
the
delete-backups
branch
4 times, most recently
from
07c82d4
to
7d2966f
Compare
Implement deletion for S3 snapshots/backups by calling the appropriate API in the DeleteSnapshot() call. In order to speed up this process, we also enhance the existing Find/ListSnapshot functions to return the originating LINSTOR remote name. This both identifies the item as a backup, and helps with the delete calls. Signed-off-by: Moritz "WanzenBug" Wanzenböck <[email protected]>
WanzenBug
force-pushed
the
delete-backups
branch
from
7d2966f
to
d026a1b
Compare
|
@rck ping :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement deletion for S3 snapshots/backups by calling the appropriate API in the DeleteSnapshot() call.
In order to speed up this process, we also enhance the existing Find/ListSnapshot functions to return the originating LINSTOR remote name. This both identifies the item as a backup, and helps with the delete calls.