fix: paginate ListNotCompletedDeployments in legacy piped - #7147
Open
Goyamjain06 wants to merge 1 commit into
Open
fix: paginate ListNotCompletedDeployments in legacy piped#7147Goyamjain06 wants to merge 1 commit into
Goyamjain06 wants to merge 1 commit into
Conversation
…ent store Signed-off-by: Goyam Jain <goyam24224@iiitd.ac.in>
Contributor
|
👋 Hi @Goyamjain06, welcome to PipeCD and thanks for opening your first pull request! We’re really happy to have you here Before your PR gets merged, please check a few important things below. Helpful resources
DCO Sign-offAll commits must include a In case you forget to sign-off your commit(s), follow these steps: For the last commit: git commit --amend --signoff
git push --force-with-leaseFor multiple commits: git rebase --signoff origin/master
git push --force-with-leaseRun checks locallyBefore pushing updates, please run: make checkThis runs the same checks as CI and helps catch issues early. 💬 Need help?If anything is unclear, feel free to ask in this PR or join us on the CNCF Slack in the #pipecd channel. Thanks for contributing to PipeCD! ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Updates the legacy
pipeddeployment store to follow the pagination cursor returned byListNotCompletedDeployments.Previously,
sync()fetched only the first page and ignored the returned cursor. It now continues fetching until the cursor is empty, ensuring all pending/planned/running deployments are included.Changes
pkg/app/piped/apistore/deploymentstore/store.goto paginateListNotCompletedDeploymentsusingresp.Cursor.store_test.gowith coverage for:ROLLING_BACKclassificationTests
go test ./pkg/app/piped/apistore/deploymentstore/...— passgo vet ./pkg/app/piped/apistore/deploymentstore/...— passmake check— Go build and web build pass. The golangci-lint step is blocked by the pinned lint image using Go 1.25.0 while the repository requires Go 1.26.2.Fixes #1937