Skip to content

Conversation

@atpugtihsrah
Copy link
Contributor

@atpugtihsrah atpugtihsrah commented Sep 18, 2025

What this PR does: Creates an RFC to document usecases and discussions around the the cancel plan preview command feature.

Why we need it: We need an RFC to document all usecases and discussion points about the cancel plan preview command feature.

Which issue(s) this PR fixes: None. This is just a documentation/RFC PR.

Fixes # This PR is related to #5276

Does this PR introduce a user-facing change?: No.

  • How are users affected by this change: 0.
  • Is this breaking change: No.
  • How to migrate (if breaking change): Not Applicable.

@atpugtihsrah atpugtihsrah self-assigned this Sep 18, 2025
@atpugtihsrah atpugtihsrah requested a review from a team as a code owner September 18, 2025 16:13
@atpugtihsrah atpugtihsrah force-pushed the 5276-cancel-plan-preview-rfc-rlin3qo2c7 branch from 49bbde8 to 0150a7a Compare September 18, 2025 16:19
@atpugtihsrah atpugtihsrah force-pushed the 5276-cancel-plan-preview-rfc-rlin3qo2c7 branch 2 times, most recently from ef84762 to 27ecbcf Compare September 28, 2025 13:01
khanhtc1202
khanhtc1202 previously approved these changes Oct 8, 2025
Copy link
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@atpugtihsrah atpugtihsrah force-pushed the 5276-cancel-plan-preview-rfc-rlin3qo2c7 branch from 27ecbcf to 5dfbc25 Compare October 8, 2025 07:22
@atpugtihsrah
Copy link
Contributor Author

atpugtihsrah commented Oct 8, 2025

I don't know why git says I dismissed your review 🙈 I accidentally did a merge commit to update my branch so I resetted the merge and then rebased my branch

Copy link
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌

@khanhtc1202 khanhtc1202 merged commit 538c2a3 into pipe-cd:master Oct 8, 2025
43 checks passed
@github-actions github-actions bot mentioned this pull request Oct 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants