-
Notifications
You must be signed in to change notification settings - Fork 201
Generate PIPECD_VERSION before running the service #6239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
linhdangduy
wants to merge
11
commits into
pipe-cd:master
Choose a base branch
from
linhdangduy:web-generate-pipecd-version-based-only-on-web-folder
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+102
−25
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
b0c1930
Revert "Revert "Improve `make run/pipecd` execution speed (#6184)" (#…
linhdangduy acb8254
get PIPECD_VERSION before docker build
linhdangduy cb463b6
copy .git to avoid error when build go
linhdangduy d52cf58
add missing --dirty to web build, run PIPECD_VERSION
linhdangduy 8aaead1
pass PIPECD_VERSION as ARG to docker build
linhdangduy 2cbb518
passing BUILD_VERSION arg to docker build
linhdangduy 989b9c7
pass BUILD_VERSION version for docker build in publish_pipedv1_exp
linhdangduy 2fd31da
Inject PIPECD_VERSION into build and dev scripts
linhdangduy a570992
assign BUILD_VERSION env variable to PIPECD_VERSION for web
linhdangduy ba6edda
unify to BUILD_VERSION
linhdangduy 0bf18ef
Merge branch 'master' into web-generate-pipecd-version-based-only-on-…
Warashi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,60 @@ | ||
| # Binaries for programs and plugins | ||
| *.exe | ||
| *.exe~ | ||
| *.dll | ||
| *.so | ||
| *.dylib | ||
|
|
||
| # Test binary, build with `go test -c` | ||
| *.test | ||
|
|
||
| # Output of the go coverage tool, specifically when used with LiteIDE | ||
| *.out | ||
|
|
||
| .DS_Store | ||
|
|
||
| # Binaries | ||
| .artifacts | ||
|
|
||
| # docs | ||
| docs | ||
|
|
||
| examples | ||
|
|
||
| # Go | ||
| /vendor | ||
|
|
||
| # nodejs | ||
| node_modules | ||
|
|
||
| # web | ||
| web/node_modules | ||
| web/dist | ||
| web/.env | ||
| web/.cache | ||
| web/coverage | ||
| pkg/app/web/.env | ||
|
|
||
| # IDE config files | ||
| .ijwb | ||
| .idea | ||
|
|
||
| .dev | ||
|
|
||
| # Terraform workspace | ||
| .terraform | ||
| .terraform-credentials | ||
|
|
||
| .rendered-manifests | ||
|
|
||
| # manifests | ||
| manifests/* | ||
|
|
||
| # gomock generated reflect files | ||
| gomock_reflect_*/ | ||
|
|
||
| # Cache | ||
| .cache | ||
|
|
||
| # hack | ||
| hack/* |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
confirmed the bug that happened on github action for the previous v0.54.0 build. For example
Expected that all of them will be fixed by this arg passing