Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LOWCAR] fixes compilation error for lowcar #268

Merged
merged 2 commits into from
Jul 19, 2023
Merged

[LOWCAR] fixes compilation error for lowcar #268

merged 2 commits into from
Jul 19, 2023

Conversation

ipleung
Copy link
Contributor

@ipleung ipleung commented Jul 19, 2023

broke in pull request #258, #256, #255

@ipleung ipleung added the bug Something isn't working label Jul 19, 2023
@ipleung ipleung self-assigned this Jul 19, 2023
benliao1
benliao1 approved these changes Jul 19, 2023
View reviewed changes
Copy link
Collaborator

@benliao1 benliao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for working on this :)

@ipleung ipleung merged commit 9d16be8 into master Jul 19, 2023
1 check passed
@ipleung ipleung deleted the rst-fix branch July 19, 2023 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benliao1 benliao1 benliao1 approved these changes

@levincent06 levincent06 Awaiting requested review from levincent06

Assignees

@ipleung ipleung

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ipleung @benliao1