Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CLI] Auto attach SHM_UI iff shm exists on start #249

Merged
merged 3 commits into from
Oct 21, 2021
Merged

[CLI] Auto attach SHM_UI iff shm exists on start #249

merged 3 commits into from
Oct 21, 2021

Conversation

levincent06
Copy link
Member

Removes need to specify "attach" arg

if shm exists when shm_ui is started
    shm_init()
else:
    create shm
    sleep(1)
    And destroy shm on exit

This is part of issue #239. Completing this for shm_ui early because it can save us some headaches from forgetting to specify "attach".

@levincent06
[CLI] Auto attach SHM_UI iff it exists
79f0873 
- Removes need to specify "attach" arg
@levincent06 levincent06 added the enhancement New feature or request label Oct 21, 2021
@levincent06 levincent06 changed the title [CLI] Auto attach SHM_UI iff it exists [CLI] Auto attach SHM_UI iff shm exists on start Oct 21, 2021
DanielMolina24
DanielMolina24 approved these changes Oct 21, 2021
View reviewed changes
Copy link
Contributor

@DanielMolina24 DanielMolina24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noice

@levincent06 levincent06 merged commit ceaef19 into master Oct 21, 2021
@levincent06 levincent06 deleted the auto_attach_ui branch October 21, 2021 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielMolina24 DanielMolina24 DanielMolina24 approved these changes

@benliao1 benliao1 Awaiting requested review from benliao1

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@levincent06 @DanielMolina24