Migrate Redux to Mobx #118
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ewc340
commented
Jun 17, 2021
| import { RootStore } from './root'; | ||
|
|
||
| export class ConsoleStore { | ||
| rootStore: typeof RootStore; |
There was a problem hiding this comment.
There should be a better way to declare the type of RootStore but we'll just leave it like this for now.
ewc340
commented
Jun 17, 2021
renderer/stores/console.ts
Outdated
| consoleUnread = false; | ||
|
|
||
| constructor(rootStore: typeof RootStore) { | ||
| makeAutoObservable(this); |
There was a problem hiding this comment.
makeAutoObservable will automatically make fields defined in the class observable
ewc340
commented
Jun 17, 2021
|
|
||
| constructor() { | ||
| this.console = new ConsoleStore(this); | ||
| /** Initialize more stores here (try to keep it in alphabetical order) */ |
There was a problem hiding this comment.
After defining a Store, make sure to create an instance of it in the RootStore here.
Closed
* Bootstrap version updated to 1.5.2 * what am i doing * Changed Graph to Container and smPush/smPull to xs * replaced Label with Badge, Navbar.header with Navbar, and Navbar.Form pullRight with Navbar * ConsoleOutput done. Fixing typescript errors on ConfigBox * straight up removed smPush and smPull * Fixed bsStyle for button and changed to variant in UpdateBox * upgrade bootstrap in Editor, upgrade glyphs to FA * ConsoleOutput done. ConfigBox has one more error * ConsoleOutput done. ConfigBox almost done (validation error left) * updated Gamepad.tsx and GamepadList.tsx * Working on Formik, added isValid props to Form.Control * add PeripheralGroup component w collapse hook * rid leftover old bootstrap * last second bootstrap fixes * fix bootstrap mostly * Fixed editor bsSize, fixed swapped editor/peripherals, added margin to peripherals * add default font value * Added margin to gamepadlist, ordered peripherals/gamepad/editor correctly * Dnav background * Added margin to top of App * look, a dark theme! Co-authored-by: meshankhosla <[email protected]> Co-authored-by: Thomas Lee <[email protected]> Co-authored-by: Andrew Dacayanan <[email protected]> Co-authored-by: Saketh Panchumarthy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to issue #111