This repository has been archived by the owner on Jul 6, 2020. It is now read-only.
Shepherd/recipemanager #733
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ianced cooked counter
…PieCentral into shepherd/recipemanager
ochan1
requested review from
FIREdog5,
Funplings,
herojelly,
kaipinryankoh,
kdarken and
rs4ostrea
as code owners
FIREdog5
reviewed
Feb 15, 2020
FIREdog5
reviewed
Feb 15, 2020
FIREdog5
reviewed
Feb 15, 2020
shepherd/RecipeManager.py
Outdated
|
|
||
| class RecipeManager(): | ||
|
|
||
| master_recipes = [RECIPE_PROBABILITIES.EASY_RECIPE, RECIPE_PROBABILITIES.MEDIUM_RECIPE, \ |
There was a problem hiding this comment.
I don't understand why this is a list of references to an empty list... it does give me a good idea of how to manage the recipes tho.
There was a problem hiding this comment.
The idea is to make it easier for us to load and reload the list by having a list that we can read from without the programmer looking back and forth
It's to make our lives and future people lives easier
Also, this is not empty (or I believe it shouldn't be)
FIREdog5
suggested changes
Feb 15, 2020
FIREdog5
reviewed
Feb 15, 2020
shepherd/RecipeManager.py
Outdated
| for item in ingredients: | ||
| if item not in recipes: | ||
| return False | ||
| return True |
There was a problem hiding this comment.
put this line inside the else statement to appease the style checker :')
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completion of Recipe Manager
Changes to Utils.py and RecipeManager.py