Adopt testify/assert for all tests #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #298 +/- ##
=======================================
Coverage 86.76% 86.76%
=======================================
Files 26 26
Lines 3061 3061
=======================================
Hits 2656 2656
Misses 348 348
Partials 57 57
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
JoeTurki
force-pushed
the
lint/test-helpers
branch
from
223932a to
5f28ee0
Compare
Love that red diff :) |
JoeTurki
force-pushed
the
lint/test-helpers
branch
from
5f28ee0 to
bab3927
Compare
JoeTurki
force-pushed
the
lint/test-helpers
branch
2 times, most recently
from
8d073e3 to
60ef99e
Compare
Use testify's assert package instead of the standard library's testing package.
JoeTurki
force-pushed
the
lint/test-helpers
branch
4 times, most recently
from
f04cc06 to
fe7fcf6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use testify's assert package instead of the standard library's testing package.
pion/.goassets#222
Reference issue
resolve #297