-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finish AV1 Implementation #295
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #295 +/- ##
==========================================
+ Coverage 85.99% 86.69% +0.69%
==========================================
Files 26 26
Lines 2913 3043 +130
==========================================
+ Hits 2505 2638 +133
+ Misses 350 348 -2
+ Partials 58 57 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
65028cb
to
4534adf
Compare
@Sean-Der I can confirm that this is working with chrome and gstreamer |
59a09ef
to
0c5defe
Compare
Thanks, I'll test it a bit more with bigger files and real video data and merge it tonight :) |
@JoeTurki you are a better tester/more detail oriented then me :) Thanks for doing this. This is going to help a lot of people building cool stuff. I am very excited for you to get the credit/attention for it! |
2146e1f
to
342e9d9
Compare
1. Rewrite the AV1 Payloader according to the spec. 2. AV1 bitstream reader. 3. Tries to optimize the use of the W field as much as possible to reduce the size of the packet. 4. Added tests around edge cases.
342e9d9
to
ee5524b
Compare
Description
Tested and works as intended. I'll update the examples in the WebRTC repo accordingly.
Reference issue
pion/webrtc#3036
pion/webrtc#2788
#273
pion/webrtc#2639