Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unmarshal only actually read bytes #257

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

braams
Copy link

@braams braams commented Jun 17, 2024

Description

The interceptor tried to unmarshal the whole buffer and didn't respect the actual packet length.

Reference issue

Fixes #255

@thatsnotright
Copy link
Contributor

Let me add some tests around this, unless you wish to, and then we can get this merged.

@thatsnotright thatsnotright self-assigned this Aug 30, 2024
Copy link

codecov bot commented Sep 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.48%. Comparing base (f42ed2b) to head (561796c).
Report is 10 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #257      +/-   ##
==========================================
- Coverage   72.56%   72.48%   -0.08%     
==========================================
  Files          79       79              
  Lines        3648     3653       +5     
==========================================
+ Hits         2647     2648       +1     
- Misses        867      869       +2     
- Partials      134      136       +2     
Flag Coverage Δ
go 72.48% <100.00%> (-0.08%) ⬇️
wasm ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Ensure reads only use length returned from upstream
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

The Jitter buffer interceptor doesn't respect the actual packet length
5 participants