Skip to content

Conversation

@stv0g
Copy link
Member

@stv0g stv0g commented May 15, 2023

Hi @ashellunts,

Here are a bunch of smaller stylistic cleanups for your recent PR (#565)

@stv0g stv0g requested a review from ashellunts May 15, 2023 21:19
Copy link
Contributor

@ashellunts ashellunts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice refactoring, thanks!
The tests also need changes due to changed functions.

@stv0g
Copy link
Member Author

stv0g commented May 16, 2023

Hi @ashellunts,

Thanks for approving the changes. I will fix the tests this evening.

@stv0g stv0g force-pushed the minor-active-tcp-fixes branch from 4cc9c98 to 0751e67 Compare May 16, 2023 18:04
@stv0g stv0g merged commit 00bbd29 into pion:master May 16, 2023
@stv0g stv0g deleted the minor-active-tcp-fixes branch May 16, 2023 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants