Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: Disable tip for sampled queries #1471

Merged
merged 8 commits into from
Jul 8, 2024
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -993,6 +993,7 @@ class DataDocQueryCellComponent extends React.PureComponent<IProps, IState> {
changeCellContext={isEditable ? this.handleChange : null}
onSamplingInfoClick={this.toggleShowTableSamplingInfoModal}
hasSamplingTables={this.hasSamplingTables}
sampleRate={this.sampleRate}
/>
);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ interface IProps {

onSamplingInfoClick?: () => void;
hasSamplingTables?: boolean;
sampleRate: number;
}

export const DataDocQueryExecutions: React.FunctionComponent<IProps> =
Expand All @@ -38,6 +39,7 @@ export const DataDocQueryExecutions: React.FunctionComponent<IProps> =
isQueryCollapsed,
onSamplingInfoClick,
hasSamplingTables,
sampleRate,
}) => {
const { cellIdToExecutionId, onQueryCellSelectExecution } =
useContext(DataDocContext);
Expand Down Expand Up @@ -155,6 +157,7 @@ export const DataDocQueryExecutions: React.FunctionComponent<IProps> =
changeCellContext={changeCellContext}
onSamplingInfoClick={onSamplingInfoClick}
hasSamplingTables={hasSamplingTables}
sampleRate={sampleRate}
/>
);

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -666,6 +666,7 @@ const QueryComposer: React.FC = () => {
hasSamplingTables={
Object.keys(samplingTables).length > 0
}
sampleRate={sampleRate}
/>
</div>
</Resizable>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,12 +17,14 @@ interface IProps {
id: number;
onSamplingInfoClick?: () => void;
hasSamplingTables?: boolean;
sampleRate: number;
}

export const QueryComposerExecution: React.FunctionComponent<IProps> = ({
id,
onSamplingInfoClick,
hasSamplingTables,
sampleRate,
}) => {
const execution = useSelector(
(state: IStoreState) => state.queryExecutions.queryExecutionById[id]
Expand Down Expand Up @@ -61,6 +63,7 @@ export const QueryComposerExecution: React.FunctionComponent<IProps> = ({
id={id}
onSamplingInfoClick={onSamplingInfoClick}
hasSamplingTables={hasSamplingTables}
sampleRate={sampleRate}
/>
</div>
);
Expand Down
3 changes: 3 additions & 0 deletions querybook/webapp/components/QueryExecution/QueryExecution.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ interface IProps {

onSamplingInfoClick?: () => void;
hasSamplingTables?: boolean;
sampleRate?: number;
}

function useQueryExecutionReduxState(queryId: number) {
Expand Down Expand Up @@ -92,6 +93,7 @@ export const QueryExecution: React.FC<IProps> = ({

onSamplingInfoClick,
hasSamplingTables,
sampleRate,
}) => {
const isEditable = useSelector((state: IStoreState) =>
canCurrentUserEditSelector(state, docId)
Expand Down Expand Up @@ -144,6 +146,7 @@ export const QueryExecution: React.FC<IProps> = ({
queryExecution={queryExecution}
onSamplingInfoClick={onSamplingInfoClick}
hasSamplingTables={hasSamplingTables}
sampleRate={sampleRate}
/>
);

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,17 +12,19 @@ interface SamplingTooltipProps {
queryExecution: IQueryExecution;
onSamplingInfoClick?: () => void;
hasSamplingTables?: boolean;
sampleRate: number;
}

export const SamplingTooltip: React.FC<SamplingTooltipProps> = ({
queryExecution: { status, id },
onSamplingInfoClick,
hasSamplingTables,
sampleRate,
}) => {
const { enabled, sampling_tool_tip_delay: delay } =
PublicConfig.table_sampling;

const queryCanBeSampled = enabled && hasSamplingTables;
const queryCanBeSampled = enabled && hasSamplingTables && sampleRate <= 0;
zhangvi7 marked this conversation as resolved.
Show resolved Hide resolved

const [showSamplingTip, setShowSamplingTip] = useState(false);

Expand Down
Loading