test: fix api::tag::tag_signal_created race-condition #380
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
problem: The following error may appear in api::tag::tag_signal_created:
```
thread 'api::tag::tag_signal_created' panicked at tests/integration/api/tag.rs:599:9:
assertion failed: storage.contains(&new_tag)
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
thread 'tokio-runtime-worker' panicked at tests/integration/api/tag.rs:436:47:
called `Result::unwrap()` on an `Err` value: PoisonError { .. }
```
cause: The rust test isn't dispatching until the signal has been
received.
solution: Dispatch until the tester `done` callback return true.
Contributor
Author
|
Woops, I forgot that line, and never triggered the bug on my end, sorry about that. This should fix #369 tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
problem: The following error may appear in api::tag::tag_signal_created:
cause: The rust test isn't dispatching until the signal has been received.
solution: Dispatch until the tester
donecallback return true.