Pass server version through to MCP server implementation #46
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
This PR updates the server initialization to properly pass the version parameter through the command chain to the MCP server implementation, replacing a hardcoded version string.
Type of Change
Related Issues
Changes Made
versionparameter toserver.Start()function signatureTitlefield to MCP server implementationTesting
This PR has been tested with:
Commands Run
Test Results
Server Package Tests (2 tests, 12 subtests - All Passed)
=== RUN TestServer_MCPClient --- PASS: TestServer_MCPClient (0.11s) === RUN TestServer_ToolFiltering === RUN TestServer_ToolFiltering/no_filtering === RUN TestServer_ToolFiltering/inclusion === RUN TestServer_ToolFiltering/exclusion === RUN TestServer_ToolFiltering/exclusion_takes_priority_over_inclusion === RUN TestServer_ToolFiltering/include_collection === RUN TestServer_ToolFiltering/exclude_collection === RUN TestServer_ToolFiltering/read-only_mode_includes_only_read-only_tools === RUN TestServer_ToolFiltering/read-only_mode_excludes_non-read-only_tools === RUN TestServer_ToolFiltering/read-only_mode_with_included_tools_still_filters_by_read-only === RUN TestServer_ToolFiltering/read-only_mode_with_excluded_read-only_tool --- PASS: TestServer_ToolFiltering (1.06s) --- PASS: TestServer_ToolFiltering/no_filtering (0.11s) --- PASS: TestServer_ToolFiltering/inclusion (0.10s) --- PASS: TestServer_ToolFiltering/exclusion (0.11s) --- PASS: TestServer_ToolFiltering/exclusion_takes_priority_over_inclusion (0.10s) --- PASS: TestServer_ToolFiltering/include_collection (0.11s) --- PASS: TestServer_ToolFiltering/exclude_collection (0.11s) --- PASS: TestServer_ToolFiltering/read-only_mode_includes_only_read-only_tools (0.11s) --- PASS: TestServer_ToolFiltering/read-only_mode_excludes_non-read-only_tools (0.11s) --- PASS: TestServer_ToolFiltering/read-only_mode_with_included_tools_still_filters_by_read-only (0.11s) --- PASS: TestServer_ToolFiltering/read-only_mode_with_excluded_read-only_tool (0.11s) PASS ok github.com/pingidentity/pingone-mcp-server/internal/server 1.386sCommand Package Tests (All Passed - 4 test suites with 50+ subtests)
Linting Results
$ make lint go tool golangci-lint run --timeout 2m # No issues found - all checks passedSummary:
Checklist
Breaking Changes
None - this is an internal refactor that doesn't affect the external API.
Additional Context
This change ensures that the server version is dynamically set from the build version rather than being hardcoded, allowing for proper version tracking in MCP server responses.