-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(release): 📦 version packages #1115
base: main
Are you sure you want to change the base?
Conversation
78861c4
to
71e23cf
Compare
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
WalkthroughThis pull request involves version updates across multiple packages in the UploadThing ecosystem. The changes primarily focus on incrementing versions for packages like Changes
Possibly related PRs
Suggested labels
Suggested reviewers
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
301c8ad
to
e4c6d50
Compare
7cb39fe
to
bc1cef3
Compare
98bd447
to
23f8eaf
Compare
9392825
to
7c45df6
Compare
e214200
to
28272b6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (4)
packages/react/CHANGELOG.md (1)
258-259
: Fix markdown formatting for URL.The bare URL should be wrapped in angle brackets for better markdown formatting.
- https://github.com/pingdotgg/uploadthing/blob/main/examples/with-novel/uploadthing/novel-plugin.ts#L50-L61 + <https://github.com/pingdotgg/uploadthing/blob/main/examples/with-novel/uploadthing/novel-plugin.ts#L50-L61>🧰 Tools
🪛 Markdownlint (0.37.0)
258-258: null
Bare URL used(MD034, no-bare-urls)
packages/expo/CHANGELOG.md (1)
130-131
: Add missing comma for better readabilityConsider adding a comma after "sometimes" to improve readability.
- fix vite monorepos sometimes complaining about `$RefreshSig$ is not a function` + fix vite monorepos sometimes, complaining about `$RefreshSig$ is not a function`🧰 Tools
🪛 LanguageTool
[uncategorized] ~130-~130: Possible missing comma found.
Context: ...https://github.com/juraj98)! - fix vite monorepos sometimes complaining about `$Refresh...(AI_HYDRA_LEO_MISSING_COMMA)
packages/svelte/CHANGELOG.md (2)
3-10
: Consider enhancing the changelog entry with more details.While the entry follows good practices by including PR/commit links and proper crediting, the description "feat: allow custom fetch override" could be more detailed to help users understand the feature's purpose and usage.
Consider expanding the description to include:
- Why this feature was added
- How users can utilize the custom fetch override
- Any breaking changes or migration notes
303-304
: Use proper Markdown link syntax for URLs.Convert the bare URL to proper Markdown link syntax for better maintainability and accessibility.
- https://docs.uploadthing.com/getting-started/svelte + [Svelte Documentation](https://docs.uploadthing.com/getting-started/svelte)🧰 Tools
🪛 Markdownlint (0.37.0)
304-304: null
Bare URL used(MD034, no-bare-urls)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yaml
is excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (38)
.changeset/nice-penguins-grow.md
(0 hunks)examples/backend-adapters/client-react/package.json
(1 hunks)examples/backend-adapters/client-vanilla/package.json
(1 hunks)examples/backend-adapters/client-vue/package.json
(1 hunks)examples/backend-adapters/package.json
(1 hunks)examples/backend-adapters/server/package.json
(1 hunks)examples/minimal-appdir/package.json
(1 hunks)examples/minimal-astro-react/package.json
(1 hunks)examples/minimal-expo/package.json
(2 hunks)examples/minimal-nuxt/package.json
(1 hunks)examples/minimal-pagedir/package.json
(1 hunks)examples/minimal-solidstart/package.json
(1 hunks)examples/minimal-sveltekit/package.json
(1 hunks)examples/minimal-tanstack-start/package.json
(1 hunks)examples/profile-picture/package.json
(2 hunks)examples/with-clerk-appdir/package.json
(1 hunks)examples/with-clerk-pagesdir/package.json
(1 hunks)examples/with-clerk-remix/package.json
(1 hunks)examples/with-drizzle-appdir/package.json
(1 hunks)examples/with-drizzle-pagesdir/package.json
(1 hunks)examples/with-novel/package.json
(2 hunks)examples/with-react-image-crop/package.json
(1 hunks)examples/with-serveractions/package.json
(1 hunks)examples/with-tailwindcss/package.json
(1 hunks)packages/expo/CHANGELOG.md
(4 hunks)packages/expo/package.json
(1 hunks)packages/nuxt/CHANGELOG.md
(7 hunks)packages/nuxt/package.json
(1 hunks)packages/react/CHANGELOG.md
(5 hunks)packages/react/package.json
(1 hunks)packages/solid/CHANGELOG.md
(5 hunks)packages/solid/package.json
(1 hunks)packages/svelte/CHANGELOG.md
(4 hunks)packages/svelte/package.json
(1 hunks)packages/uploadthing/CHANGELOG.md
(10 hunks)packages/uploadthing/package.json
(1 hunks)packages/vue/CHANGELOG.md
(4 hunks)packages/vue/package.json
(1 hunks)
💤 Files with no reviewable changes (1)
- .changeset/nice-penguins-grow.md
🚧 Files skipped from review as they are similar to previous changes (30)
- packages/vue/package.json
- examples/with-serveractions/package.json
- packages/nuxt/package.json
- examples/backend-adapters/server/package.json
- packages/uploadthing/package.json
- packages/svelte/package.json
- examples/minimal-pagedir/package.json
- examples/with-clerk-remix/package.json
- examples/with-clerk-pagesdir/package.json
- packages/solid/CHANGELOG.md
- packages/solid/package.json
- examples/minimal-astro-react/package.json
- examples/minimal-solidstart/package.json
- examples/minimal-expo/package.json
- examples/with-novel/package.json
- examples/backend-adapters/client-vanilla/package.json
- examples/backend-adapters/package.json
- examples/backend-adapters/client-react/package.json
- examples/with-clerk-appdir/package.json
- examples/minimal-sveltekit/package.json
- examples/with-drizzle-pagesdir/package.json
- examples/minimal-tanstack-start/package.json
- examples/with-react-image-crop/package.json
- examples/minimal-appdir/package.json
- examples/backend-adapters/client-vue/package.json
- examples/with-drizzle-appdir/package.json
- packages/expo/package.json
- examples/with-tailwindcss/package.json
- packages/react/package.json
- examples/minimal-nuxt/package.json
🧰 Additional context used
🪛 LanguageTool
packages/expo/CHANGELOG.md
[uncategorized] ~130-~130: Possible missing comma found.
Context: ...https://github.com/juraj98)! - fix vite monorepos sometimes complaining about `$Refresh...
(AI_HYDRA_LEO_MISSING_COMMA)
packages/nuxt/CHANGELOG.md
[style] ~236-~236: Using many exclamation marks might seem excessive (in this case: 9 exclamation marks for a text that’s 5957 characters long)
Context: ...rkowski)! - feat: vue and nuxt support! ### Patch Changes - Updated dependenc...
(EN_EXCESSIVE_EXCLAMATION)
packages/react/CHANGELOG.md
[uncategorized] ~137-~137: Possible missing comma found.
Context: ...https://github.com/juraj98)! - fix vite monorepos sometimes complaining about `$Refresh...
(AI_HYDRA_LEO_MISSING_COMMA)
packages/svelte/CHANGELOG.md
[style] ~301-~301: Using many exclamation marks might seem excessive (in this case: 14 exclamation marks for a text that’s 10055 characters long)
Context: ...@AlanAcDz! - feat: sveltekit support 📚 Read th...
(EN_EXCESSIVE_EXCLAMATION)
packages/vue/CHANGELOG.md
[uncategorized] ~168-~168: A punctuation mark might be missing here.
Context: ...hub.com//pull/886) [079b434
](https://github.com/pingdotgg/...
(AI_EN_LECTOR_MISSING_PUNCTUATION)
[style] ~272-~272: Using many exclamation marks might seem excessive (in this case: 13 exclamation marks for a text that’s 9238 characters long)
Context: ...rkowski)! - feat: vue and nuxt support! ### Patch Changes - Updated dependenc...
(EN_EXCESSIVE_EXCLAMATION)
🪛 Markdownlint (0.37.0)
packages/react/CHANGELOG.md
258-258: null
Bare URL used
(MD034, no-bare-urls)
packages/svelte/CHANGELOG.md
304-304: null
Bare URL used
(MD034, no-bare-urls)
packages/uploadthing/CHANGELOG.md
313-313: null
Bare URL used
(MD034, no-bare-urls)
487-487: null
Bare URL used
(MD034, no-bare-urls)
565-565: null
Bare URL used
(MD034, no-bare-urls)
712-712: null
Bare URL used
(MD034, no-bare-urls)
🔇 Additional comments (12)
packages/react/CHANGELOG.md (2)
3-10
: LGTM! Latest version changes are well documented.The changelog entry for version 7.2.0 properly documents:
- The minor change allowing custom fetch override
- Links to PR feat: add custom fetch override #1099 and commit hash
- Credits contributor @juliusmarminge
Line range hint
1-534
: LGTM! The changelog follows best practices.The changelog:
- Follows the Keep a Changelog format
- Uses semantic versioning
- Properly documents breaking changes
- Tracks dependencies
- Credits contributors
🧰 Tools
🪛 Markdownlint (0.37.0)
258-258: null
Bare URL used(MD034, no-bare-urls)
packages/nuxt/CHANGELOG.md (2)
3-9
: LGTM: Version bump and changelog entry are appropriate.The patch version bump to 7.1.6 correctly reflects the dependency update to @uploadthing/[email protected], following semantic versioning principles.
Line range hint
1-241
: LGTM: Changelog format is consistent.The changelog maintains a consistent format across all versions, properly documenting:
- Version numbers
- Change types
- PR references
- Commit hashes
- Contributor credits
packages/expo/CHANGELOG.md (1)
3-16
: LGTM! Well-structured changelog entry.The changelog entry for version 7.2.0 is properly formatted and accurately documents:
- The new custom fetch override feature
- Credit to contributor @juliusmarminge
- Updated dependency on @uploadthing/react
packages/svelte/CHANGELOG.md (1)
Line range hint
1-309
: Well-structured changelog format!The changelog follows the Keep a Changelog format consistently, with proper categorization of changes and clear version history.
🧰 Tools
🪛 Markdownlint (0.37.0)
304-304: null
Bare URL used(MD034, no-bare-urls)
🪛 LanguageTool
[style] ~301-~301: Using many exclamation marks might seem excessive (in this case: 14 exclamation marks for a text that’s 10055 characters long)
Context: ...@AlanAcDz! - feat: sveltekit support 📚 Read th...(EN_EXCESSIVE_EXCLAMATION)
packages/uploadthing/CHANGELOG.md (1)
3-10
: LGTM! The latest version entry is well-documented.The changelog entry for version 7.5.0 is properly formatted and includes:
- Clear description of the minor change (custom fetch override)
- PR reference (feat: add custom fetch override #1099)
- Commit hash reference
- Contributor attribution
examples/profile-picture/package.json (2)
22-22
: LGTM! Version updates align with release objectives.The updates to
@uploadthing/react
(^7.2.0) anduploadthing
(^7.5.0) match the intended release versions mentioned in the PR objectives.Also applies to: 35-35
Line range hint
22-36
: Verify dependency compatibility.Let's ensure the updated packages are compatible with other dependencies in the project.
✅ Verification successful
Dependencies are compatible with the project setup
Based on the codebase analysis, the dependencies are compatible:
@uploadthing/[email protected]
and[email protected]
are being used together in multiple example projects and the core packages- The project uses Next.js 15.1.3, which is compatible with these versions of uploadthing
- The codebase shows consistent usage patterns across different implementations (Next.js App Router, Pages Router, etc.)
- The uploadthing configuration in the project follows the latest API patterns seen in the example implementations
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Check for potential dependency conflicts and peer dependency requirements # Check if there are any conflicting peer dependencies npm info "@uploadthing/[email protected]" peerDependencies npm info "[email protected]" peerDependencies # Look for any dependency warnings in package-lock.json if [ -f "package-lock.json" ]; then jq '.packages | .[] | select(.dependencies != null) | select(.dependencies["@uploadthing/react"] != null or .dependencies["uploadthing"] != null)' package-lock.json fiLength of output: 890
Script:
#!/bin/bash # Let's try with the latest available versions to understand the peer dependencies npm info "@uploadthing/react" versions npm info "uploadthing" versions # Also check for any usage of these packages in the codebase rg -l "from ['\"]@uploadthing/react['\"]" --type ts --type tsx rg -l "from ['\"]uploadthing['\"]" --type ts --type tsx # Check Next.js version compatibility by looking at the project configuration fd "next.config" --type f --exec cat {}Length of output: 16932
Script:
#!/bin/bash # Let's check for actual usage of these packages in the codebase rg -l "from ['\"]@uploadthing/react['\"]" rg -l "from ['\"]uploadthing['\"]" # Also check for any configuration files related to uploadthing fd "uploadthing.config" --type f --exec cat {} fd "uploadthing" --type f -e ts -e js --exec cat {}Length of output: 54369
packages/vue/CHANGELOG.md (3)
3-10
: LGTM! Changelog entry follows conventions.The changelog entry for version 7.2.0 correctly documents the minor feature addition (custom fetch override) and properly credits the contributor. The version bump follows semantic versioning guidelines for feature additions.
Line range hint
1-280
: LGTM! Changelog aligns with PR objectives.The changelog updates are consistent with the PR objectives:
- Version bump to 7.2.0 matches other packages
- Custom fetch override feature is documented
- Part of the coordinated release across the UploadThing ecosystem
🧰 Tools
🪛 LanguageTool
[uncategorized] ~168-~168: A punctuation mark might be missing here.
Context: ...hub.com//pull/886) [079b434
](https://github.com/pingdotgg/...(AI_EN_LECTOR_MISSING_PUNCTUATION)
[style] ~272-~272: Using many exclamation marks might seem excessive (in this case: 13 exclamation marks for a text that’s 9238 characters long)
Context: ...rkowski)! - feat: vue and nuxt support! ### Patch Changes - Updated dependenc...(EN_EXCESSIVE_EXCLAMATION)
16-19
: Verify peer dependency compatibility with new fetch override feature.The relaxed peer dependency requirements from version 7.1.5 should be verified to ensure they support the new custom fetch override feature in version 7.2.0.
✅ Verification successful
Let me gather more information about the fetch override feature to ensure compatibility.
Let me try a different approach to check the fetch-related changes.
Peer dependency changes are compatible with the codebase
Based on the analysis of package.json files and fetch-related code across the repository:
- All client packages (@uploadthing/vue, @uploadthing/react, @uploadthing/solid, @uploadthing/svelte, @uploadthing/expo) consistently require
uploadthing: ^7.2.0
as a peer dependency- The relaxed peer dependency requirements mainly affect framework-specific versions (Vue, React, Solid, Svelte)
- The fetch-related code is properly isolated within each package's implementation
The peer dependency changes in v7.1.5 do not interfere with the fetch override functionality, as the core uploadthing package remains properly versioned across all framework implementations.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Check peer dependencies in package.json for compatibility # Find and display peer dependencies fd -t f "package.json" -x jq -r '.peerDependencies | select(. != null)'Length of output: 619
Script:
#!/bin/bash # Check for fetch override related changes in recent commits and files rg -l "fetch.*override" --type ts --type vue # Look for any fetch-related configurations or types ast-grep --pattern 'interface $_ { $$$ fetch$_?: $_ $$$ }'Length of output: 141
Script:
#!/bin/bash # Search for fetch-related code in TypeScript files rg -l "fetch" --type ts # Check package versions in package.json files fd -t f "package.json" -x jq -r '{name: .name, version: .version, dependencies: .dependencies, peerDependencies: .peerDependencies} | select(.peerDependencies != null)'Length of output: 4276
be7cad0
to
8f6da27
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (5)
packages/react/CHANGELOG.md (1)
258-258
: Consider wrapping bare URL in angle brackets.The bare URL on line 258 should be wrapped in angle brackets for better markdown formatting.
- https://github.com/pingdotgg/uploadthing/blob/main/examples/with-novel/uploadthing/novel-plugin.ts#L50-L61 + <https://github.com/pingdotgg/uploadthing/blob/main/examples/with-novel/uploadthing/novel-plugin.ts#L50-L61>🧰 Tools
🪛 Markdownlint (0.37.0)
258-258: null
Bare URL used(MD034, no-bare-urls)
packages/uploadthing/CHANGELOG.md (1)
313-313
: Consider wrapping bare URLs in angle brackets for better markdown formatting.The following URLs should be wrapped in angle brackets according to markdown best practices:
- https://github.com/Effect-TS/effect/issues/3057 + <https://github.com/Effect-TS/effect/issues/3057> - https://effect.website/docs/guides/observability/logging#built-in-loggers + <https://effect.website/docs/guides/observability/logging#built-in-loggers> - https://docs.uploadthing.com/working-with-files#accessing-files + <https://docs.uploadthing.com/working-with-files#accessing-files> - https://docs.uploadthing.com/getting-started/svelte + <https://docs.uploadthing.com/getting-started/svelte>Also applies to: 487-487, 565-565, 712-712
🧰 Tools
🪛 Markdownlint (0.37.0)
313-313: null
Bare URL used(MD034, no-bare-urls)
packages/svelte/CHANGELOG.md (2)
3-10
: Consider enhancing the feature description.While the changelog entry follows the standard format, it would be helpful to add more context about the benefits and use cases of the custom fetch override feature.
Consider expanding the description like this:
- feat: allow custom fetch override + feat: allow custom fetch override - enables users to provide their own fetch implementation for better control over network requests and compatibility with different environments
303-304
: Fix markdown formatting for the documentation URL.The bare URL should be formatted as a proper markdown link.
Apply this change:
- 📚 Read the docs to get started: - https://docs.uploadthing.com/getting-started/svelte + 📚 Read the [docs](https://docs.uploadthing.com/getting-started/svelte) to get started🧰 Tools
🪛 Markdownlint (0.37.0)
304-304: null
Bare URL used(MD034, no-bare-urls)
packages/vue/CHANGELOG.md (1)
7-10
: Consider enhancing the feature documentation.While the changelog entry is correct, it could be more helpful to users by including a brief example or more details about the custom fetch override feature, similar to how the "Go to Definition" feature was documented in version 7.1.0 (lines 76-92).
Example enhancement:
- feat: allow custom fetch override + feat: allow custom fetch override - enables users to provide their own fetch implementation for + greater control over the upload process. Example: + ```ts + useUploadThing({ + endpoint: "imageUploader", + fetch: customFetchImplementation, + }) + ```
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yaml
is excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (38)
.changeset/nice-penguins-grow.md
(0 hunks)examples/backend-adapters/client-react/package.json
(1 hunks)examples/backend-adapters/client-vanilla/package.json
(1 hunks)examples/backend-adapters/client-vue/package.json
(1 hunks)examples/backend-adapters/package.json
(1 hunks)examples/backend-adapters/server/package.json
(1 hunks)examples/minimal-appdir/package.json
(1 hunks)examples/minimal-astro-react/package.json
(1 hunks)examples/minimal-expo/package.json
(2 hunks)examples/minimal-nuxt/package.json
(1 hunks)examples/minimal-pagedir/package.json
(1 hunks)examples/minimal-solidstart/package.json
(1 hunks)examples/minimal-sveltekit/package.json
(1 hunks)examples/minimal-tanstack-start/package.json
(1 hunks)examples/profile-picture/package.json
(2 hunks)examples/with-clerk-appdir/package.json
(1 hunks)examples/with-clerk-pagesdir/package.json
(1 hunks)examples/with-clerk-remix/package.json
(1 hunks)examples/with-drizzle-appdir/package.json
(1 hunks)examples/with-drizzle-pagesdir/package.json
(1 hunks)examples/with-novel/package.json
(2 hunks)examples/with-react-image-crop/package.json
(1 hunks)examples/with-serveractions/package.json
(1 hunks)examples/with-tailwindcss/package.json
(1 hunks)packages/expo/CHANGELOG.md
(4 hunks)packages/expo/package.json
(1 hunks)packages/nuxt/CHANGELOG.md
(7 hunks)packages/nuxt/package.json
(1 hunks)packages/react/CHANGELOG.md
(5 hunks)packages/react/package.json
(1 hunks)packages/solid/CHANGELOG.md
(5 hunks)packages/solid/package.json
(1 hunks)packages/svelte/CHANGELOG.md
(4 hunks)packages/svelte/package.json
(1 hunks)packages/uploadthing/CHANGELOG.md
(10 hunks)packages/uploadthing/package.json
(1 hunks)packages/vue/CHANGELOG.md
(4 hunks)packages/vue/package.json
(1 hunks)
💤 Files with no reviewable changes (1)
- .changeset/nice-penguins-grow.md
🚧 Files skipped from review as they are similar to previous changes (31)
- packages/vue/package.json
- packages/nuxt/package.json
- examples/with-clerk-remix/package.json
- examples/with-novel/package.json
- examples/with-tailwindcss/package.json
- examples/minimal-appdir/package.json
- examples/with-drizzle-pagesdir/package.json
- examples/minimal-pagedir/package.json
- packages/expo/package.json
- packages/expo/CHANGELOG.md
- examples/minimal-sveltekit/package.json
- packages/svelte/package.json
- examples/minimal-astro-react/package.json
- examples/with-react-image-crop/package.json
- examples/backend-adapters/package.json
- examples/backend-adapters/client-vue/package.json
- examples/minimal-nuxt/package.json
- examples/minimal-tanstack-start/package.json
- examples/profile-picture/package.json
- examples/backend-adapters/client-vanilla/package.json
- examples/backend-adapters/server/package.json
- examples/with-serveractions/package.json
- examples/with-drizzle-appdir/package.json
- examples/minimal-expo/package.json
- packages/solid/package.json
- examples/minimal-solidstart/package.json
- packages/uploadthing/package.json
- examples/with-clerk-appdir/package.json
- examples/with-clerk-pagesdir/package.json
- examples/backend-adapters/client-react/package.json
- packages/react/package.json
🧰 Additional context used
🪛 LanguageTool
packages/nuxt/CHANGELOG.md
[style] ~236-~236: Using many exclamation marks might seem excessive (in this case: 9 exclamation marks for a text that’s 5957 characters long)
Context: ...rkowski)! - feat: vue and nuxt support! ### Patch Changes - Updated dependenc...
(EN_EXCESSIVE_EXCLAMATION)
packages/react/CHANGELOG.md
[uncategorized] ~137-~137: Possible missing comma found.
Context: ...https://github.com/juraj98)! - fix vite monorepos sometimes complaining about `$Refresh...
(AI_HYDRA_LEO_MISSING_COMMA)
packages/solid/CHANGELOG.md
[uncategorized] ~163-~163: A punctuation mark might be missing here.
Context: ...hub.com//pull/886) [079b434
](https://github.com/pingdotgg/...
(AI_EN_LECTOR_MISSING_PUNCTUATION)
[uncategorized] ~247-~247: A punctuation mark might be missing here.
Context: ...atch Changes - Updated dependencies [[a1481a2
](https://github.com/pingdotgg/...
(AI_EN_LECTOR_MISSING_PUNCTUATION)
packages/svelte/CHANGELOG.md
[style] ~301-~301: Using many exclamation marks might seem excessive (in this case: 14 exclamation marks for a text that’s 10055 characters long)
Context: ...@AlanAcDz! - feat: sveltekit support 📚 Read th...
(EN_EXCESSIVE_EXCLAMATION)
packages/vue/CHANGELOG.md
[style] ~272-~272: Using many exclamation marks might seem excessive (in this case: 13 exclamation marks for a text that’s 9238 characters long)
Context: ...rkowski)! - feat: vue and nuxt support! ### Patch Changes - Updated dependenc...
(EN_EXCESSIVE_EXCLAMATION)
🪛 Markdownlint (0.37.0)
packages/react/CHANGELOG.md
258-258: null
Bare URL used
(MD034, no-bare-urls)
packages/svelte/CHANGELOG.md
304-304: null
Bare URL used
(MD034, no-bare-urls)
packages/uploadthing/CHANGELOG.md
313-313: null
Bare URL used
(MD034, no-bare-urls)
487-487: null
Bare URL used
(MD034, no-bare-urls)
565-565: null
Bare URL used
(MD034, no-bare-urls)
712-712: null
Bare URL used
(MD034, no-bare-urls)
🔇 Additional comments (10)
packages/solid/CHANGELOG.md (2)
3-10
: LGTM! Changelog entry is well-formatted and consistent with PR objectives.The changelog entry for version 7.2.0 correctly documents:
- The minor version bump for the new feature
- The PR reference (feat: add custom fetch override #1099)
- The commit hash
- Proper attribution to @juliusmarminge
- Clear description of the feature (custom fetch override)
This aligns perfectly with the PR objectives which mention this feature being added across multiple packages.
Line range hint
1-155
: Well-structured changelog following best practices.The changelog demonstrates excellent maintenance with:
- Clear version headers and change categorization
- Consistent formatting across versions
- Proper linking of PRs and commits
- Detailed tracking of dependency updates
- Clear attribution to contributors
packages/react/CHANGELOG.md (2)
3-10
: LGTM! Latest version entry matches PR objectives.The changelog entry for version 7.2.0 correctly documents:
- The minor version bump (7.2.0)
- The feature addition allowing custom fetch override
- Proper attribution to contributor @juliusmarminge
- Link to the relevant PR (feat: add custom fetch override #1099)
Line range hint
1-534
: Excellent changelog structure and documentation.The changelog follows best practices:
- Clear version headers with semantic versioning
- Organized sections for Major/Minor/Patch changes
- Consistent linking to PRs and commits
- Proper attribution to contributors
- Detailed descriptions of changes
🧰 Tools
🪛 Markdownlint (0.37.0)
258-258: null
Bare URL used(MD034, no-bare-urls)
packages/uploadthing/CHANGELOG.md (1)
3-10
: LGTM! Well-structured changelog entry.The changelog entry for version 7.5.0 follows the standard format with:
- Clear version number
- Proper categorization (Minor Changes)
- Links to PR (feat: add custom fetch override #1099) and commit hash
- Credit to contributor (@juliusmarminge)
- Clear description of changes
packages/svelte/CHANGELOG.md (1)
Line range hint
1-309
: LGTM! Changelog updates align with release strategy.The changelog updates are consistent with the PR objectives, showing this is part of a coordinated release across multiple packages. The version bump to 7.2.0 and the addition of the custom fetch override feature align with the changes in other packages.
🧰 Tools
🪛 Markdownlint (0.37.0)
304-304: null
Bare URL used(MD034, no-bare-urls)
🪛 LanguageTool
[style] ~301-~301: Using many exclamation marks might seem excessive (in this case: 14 exclamation marks for a text that’s 10055 characters long)
Context: ...@AlanAcDz! - feat: sveltekit support 📚 Read th...(EN_EXCESSIVE_EXCLAMATION)
packages/vue/CHANGELOG.md (2)
3-10
: LGTM! Well-structured changelog entry.The new version entry is properly formatted, includes correct PR reference (#1099), credits the contributor, and clearly describes the feature addition. This is consistent with the coordinated release mentioned in the PR objectives.
Line range hint
11-280
: LGTM! Previous entries maintain consistent structure.The historical changelog entries follow proper semantic versioning, maintain consistent formatting, and provide clear documentation of changes with appropriate references to PRs and contributors.
🧰 Tools
🪛 LanguageTool
[style] ~272-~272: Using many exclamation marks might seem excessive (in this case: 13 exclamation marks for a text that’s 9238 characters long)
Context: ...rkowski)! - feat: vue and nuxt support! ### Patch Changes - Updated dependenc...(EN_EXCESSIVE_EXCLAMATION)
packages/nuxt/CHANGELOG.md (2)
3-9
: LGTM: Changelog entry follows the standard format.The new version entry is properly structured with:
- Clear version number (7.1.6)
- Correct categorization as patch change
- Well-formatted dependency update with commit reference
7-9
: Verify dependency update aligns with PR objectives.The update to @uploadthing/[email protected] aligns with the PR objectives, which indicate this version introduces custom fetch override capability across all packages.
Run this script to verify version consistency across related packages:
✅ Verification successful
Let me gather more information about the dependency update.
Let me gather one final piece of information to check the specific changes in version 7.2.0.
Based on the search results, I can now make a determination about the dependency update verification.
Dependency update to @uploadthing/[email protected] is correctly aligned with package requirements
The verification shows that:
- The package.json correctly specifies
@uploadthing/vue
as a workspace dependency- The CHANGELOG.md properly documents the update to version 7.2.0
- The package is actively used in the codebase:
- Imported and used in module.ts for styles and configuration
- Used in runtime components (dropzone.ts, button.ts)
- Used in composables (useUploadThing.ts)
The update appears to be properly integrated and the version bump is correctly reflected in the dependency declarations and changelog. No issues were found that would impact the package's functionality or integration.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify version consistency in package.json files # Look for @uploadthing/vue dependency version in package.json # Find and check package.json files fd "package.json" packages/nuxt | xargs cat | jq -r '.dependencies["@uploadthing/vue"] // .devDependencies["@uploadthing/vue"]' # Verify the dependency is listed in changesets fd "CHANGELOG.md" packages/nuxt | xargs rg "@uploadthing/[email protected]"Length of output: 237
Script:
#!/bin/bash # Check the actual changes in the PR for this dependency update rg -A 5 "@uploadthing/vue" packages/nuxt # Check if there are any related configuration or usage changes fd . packages/nuxt -e ts -e vue | xargs rg "uploadthing" # Look for any related changeset files fd . .changeset -e md | xargs catLength of output: 10448
Script:
#!/bin/bash # Check for any commit messages or PR descriptions related to this version rg -B 2 -A 2 "7.2.0" . # Look for any configuration changes related to fetch rg -i "fetch" packages/nuxt/srcLength of output: 102775
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
@uploadthing/[email protected]
Minor Changes
36b0df6
Thanks @juliusmarminge! - feat: allow
custom fetch override
Patch Changes
[
36b0df6
]:@uploadthing/[email protected]
Minor Changes
36b0df6
Thanks @juliusmarminge! - feat: allow
custom fetch override
@uploadthing/[email protected]
Minor Changes
36b0df6
Thanks @juliusmarminge! - feat: allow
custom fetch override
@uploadthing/[email protected]
Minor Changes
36b0df6
Thanks @juliusmarminge! - feat: allow
custom fetch override
[email protected]
Minor Changes
36b0df6
Thanks @juliusmarminge! - feat: allow
custom fetch override
@uploadthing/[email protected]
Minor Changes
36b0df6
Thanks @juliusmarminge! - feat: allow
custom fetch override
@uploadthing/[email protected]
Patch Changes
[
36b0df6
]:Summary by CodeRabbit
Dependency Updates
uploadthing
package from version 7.4.4 to 7.5.0 across multiple example projects and packagesNew Features
Package Maintenance