Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip CodeRabbit can generate a title for your PR based on the changes.Add |
|
conflicts |
|
@macroscope-app review this |
|
bug with cursor moving to the end when inserting a mention at the start: |
Let me fix this |
|
conflcits |
|
Hey @juliusmarminge i think this has been fixed in the commit 71a7473 so we can close this without merge |
What Changed
Fixed
@file/folder mentions in the message box.@mentions only worked at the end of the message.@mention in the same message.@could show old search results from the previous mention for the same message.Why
Previously:
@mentions could behave differently depending on where they were typed in the sentence.@could fail or behave inconsistently.@could show stale results from the previous search instead of starting clean for the same message.Now:
@mentions work more reliably anywhere in the message.@starts from a clean suggestion state and only shows current matches.UI Changes
None
Checklist
This PR fixes the issue #857
Note
Fix mention ping detection using expanded cursor in composer trigger resolution
detectComposerTriggerFromSnapshotin composer-logic.ts, which prefersexpandedCursorwhen available (falling back to expanding the collapsed cursor) before callingdetectComposerTrigger.'collapsed'|'expanded') cursor measurement togetComposerNodeTextLength,getAbsoluteOffsetForPoint, and$readSelectionOffsetFromEditorStatein ComposerPromptEditor.tsx so mention nodes contribute their full text length in expanded mode.nextExpandedCursorto the active pending user input answer callback.resolveComposerPathMenuEntriesin composer-path-menu.ts to hide path suggestions when the query is empty or while debouncing/fetching/loading.@pathmention trigger detection now uses the expanded cursor position, which may change which trigger is detected when the cursor is adjacent to a mention node.Macroscope summarized e1458c8.