Add Knip

[shivamhwp]

What Changed

This PR adds Knip to the repo in a minimal setup-only pass.

It introduces:

• knip as a root dev dependency
• a root bun run knip script
• a monorepo-aware knip.json covering the apps, packages, and scripts workspaces

This PR does not include any dead-code cleanup. It just wires Knip in so the current baseline is visible from CI/local runs.

Why

The earlier branch mixed Knip setup with a much larger cleanup/rebase diff. This resets the work to a small, reviewable PR that only adds the tool and its config.

Knip currently reports existing unused files, dependencies, exports, and types in the repo. That cleanup can happen in follow-up PRs once the config is accepted.

Changes

What This PR Actually Changes

• Adds a real Knip setup for this monorepo and cleans up dependency classification so knip, knip --production, and knip --strict are meaningful.
• Removes genuinely dead code: unused UI primitives, dead web helpers, dead observability files, and stale server error/schema modules.
• Shrinks runtime module surface by moving pure/test-only logic into *.shared.ts, *.logic.ts, and *.testing.ts modules instead of exporting internals from production files.
• Moves integration-only checkpoint support out of production src/ and into integration support.
• Fixes merge/review fallout so the cleanup stays aligned with current main behavior.

Notable dead code removed

• apps/web/src/components/ui/card.tsx
• apps/web/src/components/ui/field.tsx
• apps/web/src/components/ui/fieldset.tsx
• apps/web/src/components/ui/form.tsx
• apps/web/src/components/ui/input-group.tsx
• apps/web/src/components/ui/kbd.tsx
• apps/web/src/components/ui/radio-group.tsx
• apps/web/src/historyBootstrap.ts
• apps/web/src/rpc/client.ts
• apps/server/src/orchestration/Errors.ts
• apps/server/src/orchestration/Schemas.ts
• apps/server/src/persistence/Errors.ts
• dead observability tracing/file-sink files under apps/server/src/observability/

Server cleanup

• Split runtime vs shared logic in:
  • keybindings.ts -> keybindings.logic.ts
  • open.ts -> open.logic.ts / open.shared.ts
  • cli.ts -> cli.logic.ts
  • bootstrap.ts -> bootstrap.shared.ts
  • serverRuntimeStartup.ts -> serverRuntimeStartup.logic.ts
  • codexAppServerManager.ts -> codexAppServerManager.shared.ts
• Extracted large pure logic from:
  • git/Layers/GitCore.ts -> GitCore.shared.ts
  • terminal/Layers/Manager.ts -> Manager.shared.ts
  • provider layers into ClaudeProvider.logic.ts / CodexProvider.shared.ts
• Moved checkpoint-only support into apps/server/integration/support/ProjectionCheckpoints.ts
• Kept provider metrics instrumentation that runtime/tests still rely on

Web cleanup

• Split pure store logic from runtime stores:
  • store.ts -> store.logic.ts
  • uiStateStore.ts -> uiStateStore.logic.ts
• Split shared/test-only helpers from runtime modules:
  • sidebar logic
  • terminal drawer logic
  • keybindings
  • terminal context
  • pending user input
  • composer draft store
  • local storage/settings helpers
  • desktop update/timestamp helpers
• Moved test-only reset helpers out of runtime modules:
  • rpc/atomRegistry.testing.ts
  • nativeApi.testing.ts
• Fixed current-main drift in timeline/sidebar/settings/root route typing and helper boundaries

Behavior

• No intended user-facing behavior change.
• The cleanup is about deleting dead code and tightening module boundaries, not changing routes, websocket contracts, storage keys, provider semantics, or DB behavior.

Validation

• bun fmt
• bun lint
• bun typecheck
• bun run test
• bun run knip
• bun run knip -- --production
• bun run knip -- --strict

All pass.

Checklist

• This PR is small and focused
• I explained what changed and why
• I included before/after screenshots for any UI changes
• I included a video for animation/interaction changes

---

Note

Medium Risk
Moderate risk because it refactors exported surfaces and moves logic across many server modules/tests; breakages will show up at build/typecheck time but runtime behavior could regress in edge paths (CLI config, git operations, Codex manager).

Overview
Adds a unified bun run check (format/lint/typecheck/knip) and wires it into CI and contributor guidance, replacing separate quality steps.

Refactors the server codebase to satisfy Knip and reduce exported surface area by moving pure/shared/test-only helpers into new *.shared.ts, *.logic.ts, and *.testing.ts modules (e.g., cli.logic.ts, bootstrap.shared.ts, codexAppServerManager.shared.ts, and the large GitCore.shared.ts extraction), and updating tests/integration harnesses to use testing-specific persistence layers and repositories. Minor cleanup includes tightening some previously-exported types/constants to internal scope and reclassifying workspace deps as runtime dependencies.

^{Reviewed by Cursor Bugbot for commit 6e0a32f. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Add Knip to enforce unused export hygiene across the monorepo

• Adds Knip with per-workspace entry/project globs covering all apps and packages, configured to detect unused exports, types, and files.
• Adds a bun run check script in package.json that runs fmt:check, lint, typecheck, and knip in parallel; CI is updated to use this single step.
• The bulk of the PR is remediation: hundreds of exports across apps/web, apps/server, and packages/* are made internal or moved into .shared.ts, .logic.ts, or .testing.ts modules so Knip passes cleanly.
• New shared modules introduced include store.logic.ts, uiStateStore.logic.ts, terminalContext.shared.ts, keybindings.logic.ts, cli.logic.ts, open.logic.ts, open.shared.ts, GitCore.shared.ts, Manager.shared.ts (terminal), and others — each splitting testable/shared logic from layer/service entry points.
• Risk: many previously exported symbols (components, types, constants, service layers) are now internal or removed; any external code importing them will break at compile time.

^{Macroscope summarized 6e0a32f.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 164da63c-d3d7-4990-9163-bd2d48884bed

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[macroscopeapp]

Approvability

Verdict: Needs human review

Diff is too large for automated approval analysis. A human reviewer should evaluate this PR.

^{You can customize Macroscope's approvability policy. Learn more.}

Dismissing prior approval to re-evaluate eaf00af

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 108efed. Configure here.}