Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): move vite plugin to repo #9793

Merged
merged 1 commit into from
Nov 29, 2023
Merged

Conversation

zoubingwu
Copy link
Member

@zoubingwu zoubingwu commented Sep 22, 2023

What problem does this PR solve?

Issue Number: close #9630

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

Please refer to [Release Notes Language Style Guide](https://pingcap.github.io/tidb-dev-guide/contribute-to-tidb/release-notes-style-guide.html) to write a quality release note.

If you don't think this PR needs a release note then fill it with `None`.

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed do-not-merge/needs-linked-issue labels Sep 22, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 22, 2023

@wuhuizuo: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@zoubingwu
Copy link
Member Author

/retest-required

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Oct 7, 2023
@wuhuizuo
Copy link
Contributor

/retest

@ti-chi-bot ti-chi-bot bot added the lgtm label Nov 29, 2023
Copy link
Contributor

ti-chi-bot bot commented Nov 29, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lichunzhu, nongfushanquan, wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 29, 2023
Copy link
Contributor

ti-chi-bot bot commented Nov 29, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-10-07 02:27:08.794964779 +0000 UTC m=+846426.382074923: ☑️ agreed by nongfushanquan.
  • 2023-11-29 09:30:33.671402444 +0000 UTC m=+1001462.336628633: ☑️ agreed by lichunzhu.

@lichunzhu
Copy link
Contributor

/retest

1 similar comment
@wuhuizuo
Copy link
Contributor

/retest

Copy link
Contributor

ti-chi-bot bot commented Nov 29, 2023

@zoubingwu: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-dm-integration-test fcb5e5b link unknown /test dm-integration-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ti-chi-bot ti-chi-bot bot merged commit 21d17c0 into pingcap:master Nov 29, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate frontend dev dependencies
4 participants