ticdc(sink) Write DML events to pulsar #9622
Conversation
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
ti-chi-bot
bot
added
do-not-merge/release-note-label-needed
|
Hi @yumchina. Thanks for your PR. I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
ti-chi-bot
bot
added
the
size/XXL
yumchina
changed the title
asddongmen
removed
the
do-not-merge/release-note-label-needed
|
/ok-to-test |
yumchina
changed the title
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
ti-chi-bot
bot
added
the
do-not-merge/release-note-label-needed
yumchina
changed the title
| return nil, cerror.WrapError(cerror.ErrPulsarNewProducer, err) | ||
| } | ||
|
|
||
| topicManager, err := pulsarTopicManagerCreator(pConfig, client) |
There was a problem hiding this comment.
| topicManager, err := pulsarTopicManagerCreator(pConfig, client) | |
| // The topicManager is not actually used; it is only used to create dmlSink. | |
| // TODO: Find a way to remove it. | |
| topicManager, err := pulsarTopicManagerCreator(pConfig, client) |
# Conflicts: # cdc/sink/ddlsink/mq/pulsar_ddl_sink.go
asddongmen
removed
the
do-not-merge/release-note-label-needed
&& validate pulsar config
# Conflicts: # cdc/sink/ddlsink/mq/ddlproducer/pulsar_ddl_producer.go # cdc/sink/ddlsink/mq/ddlproducer/pulsar_ddl_producer_test.go # pkg/sink/pulsar/config.go # pkg/sink/pulsar/factory.go
| zap.String("changefeed", p.id.ID), zap.String("topic", topicName)) | ||
| } | ||
|
|
||
| p.client.Close() |
There was a problem hiding this comment.
Also close the client asynchronously ?
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 3AceShowHand, asddongmen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
|
/retest |
What problem does this PR solve?
add DML event to pulsar
Issue Number: ref #9413
What is changed and how it works?
Check List
Tests
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note
None