Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ticdc(sink) move pulsar sink-uri configs to sink of replica config #9578

Merged
merged 11 commits into from
Aug 24, 2023
Merged

ticdc(sink) move pulsar sink-uri configs to sink of replica config #9578

merged 11 commits into from
Aug 24, 2023

Conversation

yumchina
Copy link
Contributor

@yumchina yumchina commented Aug 15, 2023 •
edited by asddongmen
Loading

What problem does this PR solve?

move pulsar sink-uri configs to sink of replica config
Issue Number: ref #9413

What is changed and how it works?

Check List

Tests

  • Unit test

Questions

Will it cause performance regression or break compatibility?

No

Do you need to update user documentation, design documentation or monitoring documentation?

No

Release note 

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. contribution This PR is from a community contributor. needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Aug 15, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 15, 2023

Hi @yumchina. Thanks for your PR.

I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Aug 15, 2023
nongfushanquan
nongfushanquan reviewed Aug 18, 2023
View reviewed changes
pkg/config/sink.go
return pulsar.LZ4
case "zlib":
return pulsar.ZLib
case "zstd":
Copy link
Contributor

@nongfushanquan nongfushanquan Aug 18, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the snappy type supported ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pulsar client doesn't support snappy type

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Aug 21, 2023
@ti-chi-bot ti-chi-bot bot added lgtm approved and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 21, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 21, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-08-21 02:45:18.573759902 +0000 UTC m=+1117483.122775873: ☑️ agreed by nongfushanquan.
  • 2023-08-21 02:55:16.094821002 +0000 UTC m=+1118080.643836989: ☑️ agreed by asddongmen.

@nongfushanquan
Copy link
Contributor

/retest

@nongfushanquan
Copy link
Contributor

/ok-to-test

@ti-chi-bot ti-chi-bot bot added ok-to-test Indicates a PR is ready to be tested. and removed needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Aug 21, 2023
@asddongmen asddongmen removed the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Aug 21, 2023
@yumchina yumchina changed the title move pulsar sink-uri configs to sink of replica config ticdc(sink) move pulsar sink-uri configs to sink of replica config Aug 22, 2023
@ti-chi-bot ti-chi-bot bot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Aug 22, 2023
@asddongmen
Copy link
Contributor

/retest

@asddongmen
Copy link
Contributor

/test all

@asddongmen
Copy link
Contributor

/retest

@asddongmen
Copy link
Contributor

/test all

@asddongmen
Copy link
Contributor

/retest

1 similar comment
@asddongmen
Copy link
Contributor

/retest

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Aug 24, 2023
@asddongmen
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 24, 2023

@asddongmen: We have migrated to builtin LGTM and approve plugins for reviewing.

Please use /approve when you want approve this pull request.

The changes announcement: LGTM plugin changes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@asddongmen
Copy link
Contributor

/approve

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 24, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: asddongmen, nongfushanquan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot merged commit c903b87 into pingcap:master Aug 24, 2023
4 checks passed
3AceShowHand pushed a commit to 3AceShowHand/tiflow that referenced this pull request Aug 29, 2023
@yumchina @3AceShowHand
ticdc(sink) move pulsar sink-uri configs to sink of replica config (p…
24d8ded 
…ingcap#9578)

ref pingcap#9413
@kennytm kennytm mentioned this pull request Feb 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nongfushanquan nongfushanquan nongfushanquan approved these changes

@asddongmen asddongmen asddongmen approved these changes

@sdojjy sdojjy Awaiting requested review from sdojjy

@3AceShowHand 3AceShowHand Awaiting requested review from 3AceShowHand

Assignees
No one assigned
Labels
approved contribution This PR is from a community contributor. lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yumchina @nongfushanquan @asddongmen