Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changefeed(ticdc): send bootstrap message asynchronously to prevent block other changefeeds #11573

Merged
merged 7 commits into from
Sep 10, 2024

Conversation

3AceShowHand
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #11565

What is changed and how it works?

  • when the changefeed start, send bootstrap messages in a separate goroutine.
  • before the ddl manager report all bootstrap message delievered, the changefeed cannot deliever any event, skip send ddl event and scheduling tables
  • if send bootstrap messages failed, report error to the changefeed

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

`None`

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 6, 2024
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 6, 2024
cdc/owner/ddl_manager.go Outdated Show resolved Hide resolved
cdc/owner/ddl_manager.go Outdated Show resolved Hide resolved
Copy link

codecov bot commented Sep 6, 2024

Codecov Report

Attention: Patch coverage is 93.75000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 57.5857%. Comparing base (995ea76) to head (2f99aad).
Report is 6 commits behind head on master.

Additional details and impacted files
Components Coverage Δ
cdc 61.3800% <93.7500%> (+0.1492%) ⬆️
dm 51.1060% <ø> (+0.0685%) ⬆️
engine 63.4373% <ø> (+0.0635%) ⬆️
Flag Coverage Δ
unit 57.5857% <93.7500%> (+0.1123%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master     #11573        +/-   ##
================================================
+ Coverage   57.4733%   57.5857%   +0.1123%     
================================================
  Files           851        851                
  Lines        126462     126606       +144     
================================================
+ Hits          72682      72907       +225     
+ Misses        48376      48303        -73     
+ Partials       5404       5396         -8     

@3AceShowHand
Copy link
Contributor Author

/retest

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Sep 6, 2024
Copy link
Contributor

ti-chi-bot bot commented Sep 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: asddongmen, sdojjy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 9, 2024
Copy link
Contributor

ti-chi-bot bot commented Sep 9, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-09-06 23:31:14.775764052 +0000 UTC m=+53544.516188004: ☑️ agreed by asddongmen.
  • 2024-09-09 03:51:22.391641845 +0000 UTC m=+241952.132065796: ☑️ agreed by sdojjy.

@3AceShowHand
Copy link
Contributor Author

/retest

4 similar comments
@3AceShowHand
Copy link
Contributor Author

/retest

@3AceShowHand
Copy link
Contributor Author

/retest

@3AceShowHand
Copy link
Contributor Author

/retest

@3AceShowHand
Copy link
Contributor Author

/retest

@ti-chi-bot ti-chi-bot bot merged commit 2e3aade into pingcap:master Sep 10, 2024
27 of 28 checks passed
@3AceShowHand
Copy link
Contributor Author

This issue introduced by #11239, should be cherry pick back to release-7.5 and release-81.

@3AceShowHand
Copy link
Contributor Author

/cherry-pick release-7.5

@3AceShowHand
Copy link
Contributor Author

/cherry-pick release-8.1

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Sep 11, 2024
@ti-chi-bot
Copy link
Member

@3AceShowHand: new pull request created to branch release-7.5: #11588.

In response to this:

/cherry-pick release-7.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

@3AceShowHand: new pull request created to branch release-8.1: #11589.

In response to this:

/cherry-pick release-8.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot bot pushed a commit that referenced this pull request Sep 12, 2024
ti-chi-bot bot pushed a commit that referenced this pull request Sep 12, 2024
wk989898 pushed a commit to wk989898/tiflow that referenced this pull request Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ticdc: send boot strap cost too many times leading to stuck the owner
4 participants