Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sorter: fix the bug that value can be corrupted when accessing sorter #11548

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

hicqu
Copy link
Contributor

@hicqu hicqu commented Sep 2, 2024

What problem does this PR solve?

Issue Number: close #6367
Issue Number: close #10853

What is changed and how it works?

This PR is extracted from #10899 , which fixes the bug that value can be corrupted when accessing sorter.

It's hard to construct a test case for the change because the value corruption can't be reproduced stable. So we just ignore it.

Check List

Tests

  • No code

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 2, 2024
Signed-off-by: qupeng <[email protected]>
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 2, 2024
Copy link
Contributor

ti-chi-bot bot commented Sep 2, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-09-02 10:31:07.77766703 +0000 UTC m=+267592.295719954: ☑️ agreed by 3AceShowHand.
  • 2024-09-02 10:50:23.682809897 +0000 UTC m=+268748.200862821: ☑️ agreed by asddongmen.

Copy link
Contributor

ti-chi-bot bot commented Sep 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3AceShowHand, asddongmen, lidezhu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [3AceShowHand,asddongmen,lidezhu]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Sep 3, 2024
@ti-chi-bot ti-chi-bot bot merged commit e951c13 into pingcap:release-6.5 Sep 3, 2024
9 of 10 checks passed
@hicqu hicqu deleted the 6.5-fix-pebble-fetch branch September 3, 2024 03:08
@hicqu
Copy link
Contributor Author

hicqu commented Sep 3, 2024

/cherry-pick release-6.5-fips

@ti-chi-bot
Copy link
Member

@hicqu: cannot checkout release-6.5-fips: error checking out release-6.5-fips: exit status 1. output: error: pathspec 'release-6.5-fips' did not match any file(s) known to git

In response to this:

/cherry-pick release-6.5-fips

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@hicqu
Copy link
Contributor Author

hicqu commented Sep 3, 2024

/cherry-pick feature/release-6.5-fips

@ti-chi-bot
Copy link
Member

@hicqu: new pull request created to branch feature/release-6.5-fips: #11557.

In response to this:

/cherry-pick feature/release-6.5-fips

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@hicqu
Copy link
Contributor Author

hicqu commented Sep 5, 2024

/cherry-pick release-7.1

@ti-chi-bot
Copy link
Member

@hicqu: new pull request created to branch release-7.1: #11568.

In response to this:

/cherry-pick release-7.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants