Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

metrics(ticdc): fix some missing db sorter related metrics #11547

Merged
merged 7 commits into from
Sep 6, 2024
Merged

metrics(ticdc): fix some missing db sorter related metrics #11547

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
8779a27
remove some db sorter metrics
3AceShowHand Sep 2, 2024
72db29e
refactor config.
3AceShowHand Sep 2, 2024
06914b1
delete metrics in the scheduler
3AceShowHand Sep 3, 2024
25d2ead
update metrics
3AceShowHand Sep 4, 2024
5d21ef1
fix some metrics
3AceShowHand Sep 6, 2024
c7d61c1
fix make fmt
3AceShowHand Sep 6, 2024
ed56302
fix make fmt
3AceShowHand Sep 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cdc/scheduler/internal/v3/agent/agent.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,7 @@ func (a *agent) Tick(ctx context.Context) (*schedulepb.Barrier, error) {

outboundMessages = append(outboundMessages, responses...)

if err := a.sendMsgs(ctx, outboundMessages); err != nil {
if err = a.sendMsgs(ctx, outboundMessages); err != nil {
return nil, errors.Trace(err)
}

Expand Down
2 changes: 2 additions & 0 deletions cdc/scheduler/internal/v3/replication/replication_manager.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -902,6 +902,8 @@ func (r *Manager) CleanMetrics() {
slowestTableStageCheckpointTsLagHistogramVec.Reset()
slowestTableStageResolvedTsLagHistogramVec.Reset()
slowestTableRegionGaugeVec.Reset()
slowestTablePullerResolvedTs.Reset()
slowestTablePullerResolvedTsLag.Reset()
}

// SetReplicationSetForTests is only used in tests.
Expand Down
Loading
Loading