Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parser(dm): support ALTER DATABASE default database (#11504) #11543

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #11504

What problem does this PR solve?

Issue Number: close #11503

What is changed and how it works?

If the database name is omitted, the statement applies to the default database. In that case, an error occurs if there is no default database.

https://dev.mysql.com/doc/refman/8.4/en/alter-database.html

Check List

Tests

  • Unit test
  • Manual test

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

DM sync unit support ALTER DATABASE default database SQL

@ti-chi-bot ti-chi-bot added area/dm Issues or PRs related to DM. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels Aug 30, 2024
@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved The current cherry-pick pull request has not been approved and cannot be merged. cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved The current cherry-pick pull request has not been approved and cannot be merged. labels Aug 30, 2024
@ti-chi-bot ti-chi-bot bot added the approved label Aug 30, 2024
Copy link
Contributor

ti-chi-bot bot commented Aug 30, 2024

@fzzf678: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

ti-chi-bot bot commented Aug 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fzzf678, joccau, lance6716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lance6716
Copy link
Contributor

/retest

@ti-chi-bot ti-chi-bot bot merged commit 96b5cce into pingcap:release-6.5 Aug 30, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/dm Issues or PRs related to DM. cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants