Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

processor: fix a bug that will cause processor Tick get stuck when downstream is Kafka (#11339) #11387

Open
wants to merge 1 commit into
base: release-7.1
Choose a base branch
from

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #11339

What problem does this PR solve?

Issue Number: close #11340

What is changed and how it works?

Check List

Tests

  • Unit test
  • Manual test (add detailed scripts or steps below)

Deploy a cdc cluster, create two changefeeds and synchronize the same table to both Kafka and TiDB separately.

Every 20 minutes, inject CDC to network isolation:

  • First, isolate cdc to Kafka network for 10 minutes.
  • Then, 20 minutes later, isolate cdc to downstream TiDB network for 10 minutes.

Repeat this process six times.

Before this PR, the lag in the MySQL sink changefeed was influenced by the Kafka sink changefeed when network isolation was introduced between CDC and Kafka:
nHHvw2tHOE

After this PR, only Kafka sink changefeed lag increasing during network isolation injection:
image

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

Fix a bug that causes the processor tick to get stuck when the downstream is Kafka and becomes unreachable.```

@ti-chi-bot ti-chi-bot added affect-ticdc-config-docs Pull requests that affect TiCDC configuration docs. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR. labels Jul 4, 2024
@ti-chi-bot ti-chi-bot bot added the do-not-merge/cherry-pick-not-approved The current cherry-pick pull request has not been approved and cannot be merged. label Jul 4, 2024
Copy link
Contributor

ti-chi-bot bot commented Jul 4, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign yujuncen for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

ti-chi-bot bot commented Jul 4, 2024

This cherry pick PR is for a release branch and has not yet been approved by triage owners.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick:

  1. It must be approved by the approvers firstly.
  2. AFTER it has been approved by approvers, please wait for the cherry-pick merging approval from triage owners.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

ti-chi-bot bot commented Jul 4, 2024

@ti-chi-bot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
jenkins-ticdc/verify a56e151 link true /test verify
pull-dm-integration-test a56e151 link true /test dm-integration-test
pull-cdc-integration-storage-test a56e151 link true /test cdc-integration-storage-test
pull-cdc-integration-kafka-test a56e151 link true /test cdc-integration-kafka-test
pull-cdc-integration-mysql-test a56e151 link true /test cdc-integration-mysql-test
pull-dm-compatibility-test a56e151 link true /test dm-compatibility-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affect-ticdc-config-docs Pull requests that affect TiCDC configuration docs. do-not-merge/cherry-pick-not-approved The current cherry-pick pull request has not been approved and cannot be merged. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants