Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

util(dm): update checking for fake rotate event #11360

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

util(dm): update checking for fake rotate event #11360

wants to merge 5 commits into from
+158 −158

Conversation

lance6716
Copy link
Contributor

@lance6716 lance6716 commented Jun 27, 2024 •
edited
Loading

What problem does this PR solve?

Issue Number: close #11381

What is changed and how it works?

make fake rotate event checking more strict

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note 

`None`.

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. area/dm Issues or PRs related to DM. labels Jun 27, 2024
@lance6716 lance6716 added the skip-issue-check Indicates that a PR no need to check linked issue. label Jun 27, 2024
@ti-chi-bot ti-chi-bot bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed do-not-merge/needs-linked-issue labels Jun 27, 2024
@lance6716
Copy link
Contributor Author

/cc @GMHDBJD

@ti-chi-bot ti-chi-bot bot requested a review from GMHDBJD June 27, 2024 06:25
@lance6716
fix UT
a03be85 
Signed-off-by: lance6716 <[email protected]>
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 27, 2024
@lance6716
fix UT
8084946 
Signed-off-by: lance6716 <[email protected]>
@codecov Codecov
Copy link

codecov bot commented Jun 27, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 57.8337%. Comparing base (467a152) to head (cdd034a).
Report is 7 commits behind head on master.

Additional details and impacted files
Components Coverage Δ
cdc 61.7536% <ø> (∅)
dm 51.2655% <0.0000%> (∅)
engine 63.4161% <ø> (+0.0494%) ⬆️
Flag Coverage Δ
unit 57.8337% <0.0000%> (-5.5331%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master     #11360        +/-   ##
================================================
- Coverage   63.3667%   57.8337%   -5.5331%     
================================================
  Files           163        849       +686     
  Lines         14162     126760    +112598     
================================================
+ Hits           8974      73310     +64336     
- Misses         4621      48024     +43403     
- Partials        567       5426      +4859

@lance6716
try to fix
04d70df 
Signed-off-by: lance6716 <[email protected]>
@lance6716 lance6716 changed the title util(dm): update checking for fake rotate event [WIP]util(dm): update checking for fake rotate event Jun 28, 2024
@ti-chi-bot ti-chi-bot bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 28, 2024
@lance6716
fix CI
cdd034a 
Signed-off-by: lance6716 <[email protected]>
@lance6716 lance6716 changed the title [WIP]util(dm): update checking for fake rotate event util(dm): update checking for fake rotate event Jul 2, 2024
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 2, 2024
@lance6716
Copy link
Contributor Author

/check-issue-triage-complete

GMHDBJD
GMHDBJD approved these changes Jul 3, 2024
View reviewed changes
Copy link
Contributor

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lance6716
Copy link
Contributor Author

/check-issue-triage-complete

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 3, 2024

@lyzx2001: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lance6716
Copy link
Contributor Author

/cc @D3Hunter

@ti-chi-bot ti-chi-bot bot requested a review from D3Hunter July 4, 2024 07:19
lance6716
lance6716 commented Jul 5, 2024
View reviewed changes
dm/relay/relay_writer_test.go
"time"

gmysql "github.com/go-mysql-org/go-mysql/mysql"
"github.com/go-mysql-org/go-mysql/replication"
"github.com/pingcap/check"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the file change is caused by switching testing framework

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: D3Hunter, GMHDBJD, lyzx2001

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 5, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-07-03 06:54:18.403909131 +0000 UTC m=+1393784.889397963: ☑️ agreed by GMHDBJD.
  • 2024-07-05 07:34:58.833149205 +0000 UTC m=+1569025.318638036: ☑️ agreed by D3Hunter.

@lance6716
Copy link
Contributor Author

/retest

2 similar comments
@lance6716
Copy link
Contributor Author

/retest

@lance6716
Copy link
Contributor Author

/retest

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 5, 2024

@lance6716: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-dm-integration-test cdd034a link true /test dm-integration-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@D3Hunter D3Hunter D3Hunter approved these changes

@GMHDBJD GMHDBJD GMHDBJD approved these changes

@lyzx2001 lyzx2001 lyzx2001 approved these changes

Assignees
No one assigned
Labels
approved area/dm Issues or PRs related to DM. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. skip-issue-check Indicates that a PR no need to check linked issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DM has wrong checking condition for fake roate event
4 participants
@lance6716 @D3Hunter @GMHDBJD @lyzx2001