Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metrics(ticdc): add kafka compression ratio description for grafana #11348

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

sdojjy
Copy link
Member

@sdojjy sdojjy commented Jun 26, 2024

What problem does this PR solve?

Issue Number: close #11347

What is changed and how it works?

add kafka compression ratio description for grafana

image

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

`None`.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 26, 2024
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jun 26, 2024
Copy link
Contributor

ti-chi-bot bot commented Jun 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3AceShowHand, asddongmen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [3AceShowHand,asddongmen]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 26, 2024
Copy link
Contributor

ti-chi-bot bot commented Jun 26, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-06-26 07:36:43.843256601 +0000 UTC m=+791530.328745435: ☑️ agreed by 3AceShowHand.
  • 2024-06-26 07:38:13.392035974 +0000 UTC m=+791619.877524806: ☑️ agreed by asddongmen.

@sdojjy
Copy link
Member Author

sdojjy commented Jun 26, 2024

/retest-required

2 similar comments
@sdojjy
Copy link
Member Author

sdojjy commented Jun 26, 2024

/retest-required

@sdojjy
Copy link
Member Author

sdojjy commented Jun 26, 2024

/retest-required

Copy link

codecov bot commented Jun 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.6426%. Comparing base (a2e6219) to head (d2918fd).

Additional details and impacted files
Components Coverage Δ
cdc 61.4595% <ø> (+0.0304%) ⬆️
dm 51.1990% <ø> (-0.0283%) ⬇️
engine 63.4091% <ø> (+0.0352%) ⬆️
Flag Coverage Δ
unit 57.6426% <ø> (+0.0079%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master     #11348        +/-   ##
================================================
+ Coverage   57.6347%   57.6426%   +0.0079%     
================================================
  Files           849        849                
  Lines        126160     126160                
================================================
+ Hits          72712      72722        +10     
+ Misses        48048      48038        -10     
  Partials       5400       5400                

@ti-chi-bot ti-chi-bot bot merged commit 401b2bc into pingcap:master Jun 26, 2024
28 checks passed
@sdojjy sdojjy deleted the add-compression-ratio-description branch June 27, 2024 02:06
@sdojjy sdojjy added needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. labels Jun 27, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #11352.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #11353.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects-7.5 affects-8.1 approved lgtm needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

metrics(ticdc): add kafka compression ratio description for grafana
4 participants