Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: simply the release version composing step #11344

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

build: simply the release version composing step #11344

wants to merge 1 commit into from
+1 −12

Conversation

wuhuizuo
Copy link
Contributor

@wuhuizuo wuhuizuo commented Jun 25, 2024 •
edited
Loading

What problem does this PR solve?

Issue Number: close #11345

What is changed and how it works?

keep same with tidb and pd components.

master branche:

  • v8.3.0-master-dirty => v8.3.0-alpha-1-ga2e621937-dirty
  • v8.3.0-master => v8.3.0-alpha-1-ga2e621937

release branches:

  • v8.2.0-alpha-90-ga2e621937 // first version of the branch will not be changed.
  • v8.1.0-90-ga2e621937 // new LTS patch versions also will not be changed.
  • v8.2.0 // when it taged in RC and GA building.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note 

None

@wuhuizuo
build: simply the release version composing step
19a8dfd 
keep same with tidb, pd components.

master branche:
- v8.3.0-master-dirty => v8.3.0-alpha-1-ga2e621937-dirty
- v8.3.0-master => v8.3.0-alpha-1-ga2e621937

release branches:
- v8.2.0-alpha-90-ga2e621937 // first version of the branch will not be changed.
- v8.1.0-90-ga2e621937 // new LTS patch versions also will not be changed.
- v8.2.0 // when it taged in RC and GA building.

Signed-off-by: wuhuizuo <[email protected]>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jun 25, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 25, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign ianthereal for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 25, 2024
@wuhuizuo
Copy link
Contributor Author

/cc @CharlesCheung96 @flowbehappy @Benjamin2037

/hold
need detail talk.

@ti-chi-bot ti-chi-bot bot requested a review from Benjamin2037 June 25, 2024 11:32
@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 25, 2024
@wuhuizuo
Copy link
Contributor Author

/run-check-issue-triage-complete

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/needs-triage-completed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jun 25, 2024
@codecov Codecov
Copy link

codecov bot commented Jun 25, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.6347%. Comparing base (a2e6219) to head (19a8dfd).

Additional details and impacted files
Components Coverage Δ
cdc 61.4370% <ø> (+0.0080%) ⬆️
dm 51.2111% <ø> (-0.0162%) ⬇️
engine 63.3950% <ø> (+0.0211%) ⬆️
Flag Coverage Δ
unit 57.6347% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@@             Coverage Diff             @@
##             master     #11344   +/-   ##
===========================================
  Coverage   57.6347%   57.6347%           
===========================================
  Files           849        849           
  Lines        126160     126160           
===========================================
  Hits          72712      72712           
+ Misses        48048      48047    -1     
- Partials       5400       5401    +1

@wuhuizuo
Copy link
Contributor Author

@wuhuizuo: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cdc-integration-mysql-test 19a8dfd link true /test cdc-integration-mysql-test
Full PR test history. Your PR dashboard.

Oh, flaky tests!

@wuhuizuo
Copy link
Contributor Author

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Benjamin2037 Benjamin2037 Awaiting requested review from Benjamin2037

@CharlesCheung96 CharlesCheung96 Awaiting requested review from CharlesCheung96

@flowbehappy flowbehappy Awaiting requested review from flowbehappy

Assignees
No one assigned
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can we simply the release version in Makefile just like TiDB and PD components?
1 participant
@wuhuizuo